Page MenuHomePhabricator

Manually set "max_allowed_packet" to 1GB for "mysqldump"
ClosedPublic

Authored by epriestley on Dec 20 2017, 5:50 PM.
Tags
None
Referenced Files
F13086717: D18834.diff
Thu, Apr 25, 12:41 AM
F13080637: D18834.diff
Wed, Apr 24, 9:24 AM
Unknown Object (File)
Mon, Apr 22, 1:25 PM
Unknown Object (File)
Fri, Apr 19, 7:02 PM
Unknown Object (File)
Thu, Apr 18, 11:32 AM
Unknown Object (File)
Tue, Apr 2, 8:22 AM
Unknown Object (File)
Sun, Mar 31, 6:48 PM
Unknown Object (File)
Sat, Mar 30, 5:35 AM
Subscribers
None

Details

Summary

We have one production instance with failing database backups since they recently uploaded a 52MB hunk. The production configuration specifies a 64MB "max_allowed_packet" in [mysqld], but this doesn't apply to mysqldump (we'd need to specify it in a separate [mysqldump] section) and mysqldump runs with an effective limit of the default (16MB).

We could change our production config to specify a value in [mysqldump], but just change it unconditionally at execution time since there's no reason for any user to ever want this command to fail because they have too much data.

Test Plan

Dumped locally, will verify production backup goes through cleanly.

Diff Detail

Repository
rP Phabricator
Branch
dump1
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 18962
Build 25574: Run Core Tests
Build 25573: arc lint + arc unit

Event Timeline

This revision is now accepted and ready to land.Dec 20 2017, 6:22 PM
This revision was automatically updated to reflect the committed changes.

I deployed this narrowly to the affected shard and verified the backlog flushed and database dumped properly.