Restore the "Download from Git LFS" UI button to Diffusion
ClosedPublic
Actions

Authored by epriestley on Dec 13 2017, 2:04 PM.

Details

Reviewers

amckinley

Maniphest Tasks

T7789: Support Git Large File Storage

Commits

rP5295840a4cf9: Restore the "Download from Git LFS" UI button to Diffusion

Summary

Depends on D18827. Ref T7789. See PHI204. See PHI131. This button got accidentally removed in Diffusion refactoring ($data is no longer used).

Test Plan

Screen Shot 2017-12-13 at 6.03.15 AM.png (216×703 px, 14 KB)

Diff Detail

Repository

rP Phabricator

Branch

lfs3

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 18945
Build 25550: Run Core Tests
Build 25549: arc lint + arc unit

Event Timeline

epriestley created this revision.Dec 13 2017, 2:04 PM

Harbormaster completed remote builds in B18945: Diff 45172.Dec 13 2017, 2:05 PM

epriestley requested review of this revision.Dec 13 2017, 2:05 PM

epriestley added a child revision: D18830: Stop trying to assess the image dimensions of large files and file chunks.Dec 13 2017, 2:48 PM

Cool!

This revision is now accepted and ready to land.Dec 14 2017, 5:51 PM

Closed by commit rP5295840a4cf9: Restore the "Download from Git LFS" UI button to Diffusion (authored by epriestley). · Explain WhyDec 18 2017, 5:13 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

diffusion/

controller/

DiffusionBrowseController.php

5 lines

Diff 45172

View Options

src/applications/diffusion/controller/DiffusionBrowseController.php

Restore the "Download from Git LFS" UI button to DiffusionClosedPublicActions