Page MenuHomePhabricator

Move the Git LFS gate to dedicated (non-prototype) config
ClosedPublic

Authored by epriestley on Dec 13 2017, 1:43 PM.

Details

Summary

See PHI131. Ref T7789. Although this probably isn't 100% complete, there don't seem to be any actual, known, practical blocking issues remaining (everything is either heresay or not reproducible).

Test Plan

Tried to push LFS locally, got blocked with a helpful message. Enabled setting, tried to push LFS locally, got a successful push.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Looks good except for nits.

src/applications/diffusion/config/PhabricatorDiffusionConfigOptions.php
121

"Enable"?

125

Or change this to "allow"

128

"a Git extension"

129

I'm just quibbling, but technically, the files aren't stored in the repository itself. FWIW, here's the blurb from the project page if we want to use it:

Git Large File Storage (LFS) replaces large files such as audio samples, videos, datasets, and graphics with text pointers inside Git, while storing the file contents on a remote server like GitHub.com or GitHub Enterprise.

This revision is now accepted and ready to land.Dec 14 2017, 5:47 PM
  • Wordsmithing; kept "allow" (this mirrors existing options like "diffusion.allow-http-auth") but improved consistency and accuracy.
This revision was automatically updated to reflect the committed changes.