Differential D18825

Move the Git LFS gate to dedicated (non-prototype) config
ClosedPublic
Actions

Authored by epriestley on Dec 13 2017, 1:43 PM.

Details

Reviewers

amckinley

Maniphest Tasks

T7789: Support Git Large File Storage

Commits

rPe34b4bbd907e: Move the Git LFS gate to dedicated (non-prototype) config

Summary

See PHI131. Ref T7789. Although this probably isn't 100% complete, there don't seem to be any actual, known, practical blocking issues remaining (everything is either heresay or not reproducible).

Test Plan

Tried to push LFS locally, got blocked with a helpful message. Enabled setting, tried to push LFS locally, got a successful push.

Diff Detail

Repository

rP Phabricator

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

epriestley created this revision.Dec 13 2017, 1:43 PM

Harbormaster completed remote builds in B18942: Diff 45169.Dec 13 2017, 1:44 PM

epriestley requested review of this revision.Dec 13 2017, 1:44 PM

epriestley added a child revision: D18827: Add a Herald pre-commit field for detecting LFS usage.Dec 13 2017, 1:59 PM

Looks good except for nits.

src/applications/diffusion/config/PhabricatorDiffusionConfigOptions.php
121	"Enable"?
125	Or change this to "allow"
128	"a Git extension"
129	I'm just quibbling, but technically, the files aren't stored in the repository itself. FWIW, here's the blurb from the project page if we want to use it: Git Large File Storage (LFS) replaces large files such as audio samples, videos, datasets, and graphics with text pointers inside Git, while storing the file contents on a remote server like GitHub.com or GitHub Enterprise.