Page MenuHomePhabricator

Fix an issue where Diffusion could fatal if the default branch was deleted
ClosedPublic

Authored by epriestley on Nov 30 2017, 8:35 PM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Apr 19, 4:28 PM
Unknown Object (File)
Wed, Apr 17, 2:46 PM
Unknown Object (File)
Sun, Mar 31, 6:27 PM
Unknown Object (File)
Feb 17 2024, 11:06 AM
Unknown Object (File)
Jan 20 2024, 10:50 PM
Unknown Object (File)
Jan 10 2024, 9:09 PM
Unknown Object (File)
Jan 5 2024, 7:15 PM
Unknown Object (File)
Jan 3 2024, 11:12 AM
Subscribers
None

Details

Summary

See PHI234. In T12931 we improved the behavior of Diffusion when a repository's default branch is set to a branch that does not exist, but in T11823 the way refcursors work changed, and we can now get a cursor (just with no positions) back for a deleted branch. When we did, we didn't handle things gracefully.

Test Plan
  • Set default branch to a deleted branch, saw nice error instead of fatal.
  • Set default branch to a nonexistent branch which never existed, saw nice error.
  • Set default branch to existing "master", saw repository normally.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable