Page MenuHomePhabricator

Fix an issue where Diffusion could fatal if the default branch was deleted
ClosedPublic

Authored by epriestley on Nov 30 2017, 8:35 PM.
Tags
None
Referenced Files
F18999025: D18811.diff
Thu, Nov 20, 7:59 PM
F18867845: D18811.id.diff
Tue, Nov 4, 3:06 AM
F18864452: D18811.diff
Mon, Nov 3, 5:41 AM
F18832584: D18811.id45138.diff
Sat, Oct 25, 10:11 PM
F18832583: D18811.id45132.diff
Sat, Oct 25, 10:11 PM
F18832582: D18811.id.diff
Sat, Oct 25, 10:11 PM
F18831584: D18811.diff
Sat, Oct 25, 1:45 PM
F18766697: D18811.id45138.diff
Oct 7 2025, 6:00 PM
Subscribers
None

Details

Summary

See PHI234. In T12931 we improved the behavior of Diffusion when a repository's default branch is set to a branch that does not exist, but in T11823 the way refcursors work changed, and we can now get a cursor (just with no positions) back for a deleted branch. When we did, we didn't handle things gracefully.

Test Plan
  • Set default branch to a deleted branch, saw nice error instead of fatal.
  • Set default branch to a nonexistent branch which never existed, saw nice error.
  • Set default branch to existing "master", saw repository normally.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable