Page MenuHomePhabricator

Allow "arc diff --draft" to create revisions as drafts more forcefully
ClosedPublic

Authored by epriestley on Nov 14 2017, 8:22 PM.
Tags
None
Referenced Files
F15484735: D18772.diff
Wed, Apr 9, 7:48 PM
F15472660: D18772.id45044.diff
Sat, Apr 5, 3:22 PM
F15470093: D18772.id45046.diff
Fri, Apr 4, 7:39 PM
F15436878: D18772.id45046.diff
Tue, Mar 25, 4:42 PM
F15427844: D18772.diff
Sun, Mar 23, 4:19 PM
F15427237: D18772.id45046.diff
Sun, Mar 23, 1:24 PM
F15368161: D18772.diff
Mar 12 2025, 12:25 AM
F15354715: D18772.diff
Mar 11 2025, 5:34 AM
Subscribers
None

Details

Summary

Depends on D18771. See PHI206. Currently, arc diff --draft only holds revisions in draft mode: it doesn't put them into draft mode if the install isn't configured to use draft mode.

Instead, make it a bit more forceful so that arc diff --draft can create into draft mode explicitly even if protoypes are off. This aligns with expection a little more clearly.

Test Plan

Ran arc diff --draft with prototypes off, got a revision held in draft mode.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable