Page MenuHomePhabricator

Allow "arc diff --draft" to create revisions as drafts more forcefully
ClosedPublic

Authored by epriestley on Nov 14 2017, 8:22 PM.
Tags
None
Referenced Files
F14072926: D18772.diff
Wed, Nov 20, 10:13 PM
Unknown Object (File)
Tue, Nov 19, 10:24 PM
Unknown Object (File)
Sat, Nov 16, 11:28 AM
Unknown Object (File)
Tue, Nov 12, 3:12 PM
Unknown Object (File)
Fri, Nov 8, 1:14 PM
Unknown Object (File)
Sun, Oct 27, 6:32 AM
Unknown Object (File)
Oct 20 2024, 8:22 PM
Unknown Object (File)
Oct 13 2024, 2:29 AM
Subscribers
None

Details

Summary

Depends on D18771. See PHI206. Currently, arc diff --draft only holds revisions in draft mode: it doesn't put them into draft mode if the install isn't configured to use draft mode.

Instead, make it a bit more forceful so that arc diff --draft can create into draft mode explicitly even if protoypes are off. This aligns with expection a little more clearly.

Test Plan

Ran arc diff --draft with prototypes off, got a revision held in draft mode.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable