Page MenuHomePhabricator

Allow "arc diff --draft" to create revisions as drafts more forcefully
ClosedPublic

Authored by epriestley on Nov 14 2017, 8:22 PM.
Tags
None
Referenced Files
F19059263: D18772.id.diff
Sat, Nov 29, 4:59 AM
F19051771: D18772.diff
Fri, Nov 28, 2:04 AM
F18841958: D18772.id45046.diff
Oct 28 2025, 12:31 PM
F18841697: D18772.id45044.diff
Oct 28 2025, 10:37 AM
F18837419: D18772.id.diff
Oct 27 2025, 5:11 AM
F18833340: D18772.diff
Oct 26 2025, 2:38 AM
F18697362: D18772.id45046.diff
Sep 27 2025, 9:34 AM
F18628619: D18772.diff
Sep 16 2025, 6:44 AM
Subscribers
None

Details

Summary

Depends on D18771. See PHI206. Currently, arc diff --draft only holds revisions in draft mode: it doesn't put them into draft mode if the install isn't configured to use draft mode.

Instead, make it a bit more forceful so that arc diff --draft can create into draft mode explicitly even if protoypes are off. This aligns with expection a little more clearly.

Test Plan

Ran arc diff --draft with prototypes off, got a revision held in draft mode.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable