Page MenuHomePhabricator

Allow "arc diff --draft" to create revisions as drafts more forcefully
ClosedPublic

Authored by epriestley on Nov 14 2017, 8:22 PM.
Tags
None
Referenced Files
F18509184: D18772.id.diff
Fri, Sep 5, 3:16 AM
F18501807: D18772.diff
Thu, Sep 4, 9:58 PM
F18349739: D18772.diff
Tue, Aug 26, 6:47 PM
F18242825: D18772.id.diff
Thu, Aug 21, 4:38 AM
F18225911: D18772.diff
Wed, Aug 20, 2:54 AM
F18098485: D18772.id45044.diff
Aug 8 2025, 8:28 PM
F18083940: D18772.id45044.diff
Aug 5 2025, 12:32 PM
F17870375: D18772.diff
Jul 28 2025, 1:47 PM
Subscribers
None

Details

Summary

Depends on D18771. See PHI206. Currently, arc diff --draft only holds revisions in draft mode: it doesn't put them into draft mode if the install isn't configured to use draft mode.

Instead, make it a bit more forceful so that arc diff --draft can create into draft mode explicitly even if protoypes are off. This aligns with expection a little more clearly.

Test Plan

Ran arc diff --draft with prototypes off, got a revision held in draft mode.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable