Page MenuHomePhabricator

Allow "arc diff --draft" to create revisions as drafts more forcefully
ClosedPublic

Authored by epriestley on Nov 14 2017, 8:22 PM.
Tags
None
Referenced Files
F17715124: D18772.diff
Thu, Jul 17, 3:09 PM
Unknown Object (File)
Apr 24 2025, 3:36 PM
Unknown Object (File)
Apr 21 2025, 12:17 PM
Unknown Object (File)
Apr 9 2025, 7:48 PM
Unknown Object (File)
Apr 5 2025, 3:22 PM
Unknown Object (File)
Apr 4 2025, 7:39 PM
Unknown Object (File)
Mar 25 2025, 4:42 PM
Unknown Object (File)
Mar 23 2025, 4:19 PM
Subscribers
None

Details

Summary

Depends on D18771. See PHI206. Currently, arc diff --draft only holds revisions in draft mode: it doesn't put them into draft mode if the install isn't configured to use draft mode.

Instead, make it a bit more forceful so that arc diff --draft can create into draft mode explicitly even if protoypes are off. This aligns with expection a little more clearly.

Test Plan

Ran arc diff --draft with prototypes off, got a revision held in draft mode.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable