Page MenuHomePhabricator

Allow "arc diff --draft" to create revisions as drafts more forcefully
ClosedPublic

Authored by epriestley on Nov 14 2017, 8:22 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Sep 5, 4:19 PM
Unknown Object (File)
Aug 5 2026, 8:33 PM
Unknown Object (File)
Jul 31 2026, 2:45 AM
Unknown Object (File)
Jul 11 2026, 12:27 AM
Unknown Object (File)
Jul 4 2026, 3:04 PM
Unknown Object (File)
Apr 12 2026, 2:16 AM
Unknown Object (File)
Mar 4 2026, 10:38 AM
Unknown Object (File)
Nov 29 2025, 4:59 AM
Subscribers
None

Details

Summary

Depends on D18771. See PHI206. Currently, arc diff --draft only holds revisions in draft mode: it doesn't put them into draft mode if the install isn't configured to use draft mode.

Instead, make it a bit more forceful so that arc diff --draft can create into draft mode explicitly even if protoypes are off. This aligns with expection a little more clearly.

Test Plan

Ran arc diff --draft with prototypes off, got a revision held in draft mode.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable