Page MenuHomePhabricator

Allow "arc diff --draft" to create revisions as drafts more forcefully
ClosedPublic

Authored by epriestley on Nov 14 2017, 8:22 PM.
Tags
None
Referenced Files
F14987705: D18772.diff
Sun, Feb 16, 3:06 PM
Unknown Object (File)
Tue, Feb 11, 6:40 AM
Unknown Object (File)
Tue, Feb 11, 4:26 AM
Unknown Object (File)
Sun, Feb 9, 4:51 AM
Unknown Object (File)
Sun, Feb 9, 4:51 AM
Unknown Object (File)
Sun, Feb 9, 4:51 AM
Unknown Object (File)
Sun, Feb 9, 4:51 AM
Unknown Object (File)
Sat, Feb 8, 8:41 PM
Subscribers
None

Details

Summary

Depends on D18771. See PHI206. Currently, arc diff --draft only holds revisions in draft mode: it doesn't put them into draft mode if the install isn't configured to use draft mode.

Instead, make it a bit more forceful so that arc diff --draft can create into draft mode explicitly even if protoypes are off. This aligns with expection a little more clearly.

Test Plan

Ran arc diff --draft with prototypes off, got a revision held in draft mode.

Diff Detail

Repository
rP Phabricator
Branch
draft2
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 18826
Build 25376: Run Core Tests
Build 25375: arc lint + arc unit