Include "Draft" revisions in Differential legacy status queries
ClosedPublic
Actions

Authored by epriestley on Nov 7 2017, 1:17 PM.

Details

Reviewers

amckinley

Maniphest Tasks

T2543: Add a formal "Draft" / "Not Yet Ready for Review" state to Differential

Commits

rP759c757264c8: Include "Draft" revisions in Differential legacy status queries

Summary

See PHI199. Ref T2543. When you run a RevisionQuery with a legacy status constraint (via differential.query), we currently don't match "Draft" revisions.

Use the actual complete map from DifferentialRevisionStatus instead of hard coding the status list so "Draft" is included.

Test Plan

Ran differential.query with ids and status for a draft revision.
Before patch: revision not returned in results.
After patch: revision returned in results.

(Note that it returns as "Needs Review", for compatibility.)

Diff Detail

Repository

rP Phabricator

Branch

draft1

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 18808
Build 25353: Run Core Tests
Build 25352: arc lint + arc unit

Event Timeline

epriestley created this revision.Nov 7 2017, 1:17 PM

Harbormaster completed remote builds in B18808: Diff 45030.Nov 7 2017, 1:18 PM

epriestley requested review of this revision.Nov 7 2017, 1:18 PM

amckinley accepted this revision.Nov 7 2017, 9:10 PM

This revision is now accepted and ready to land.Nov 7 2017, 9:10 PM

Closed by commit rP759c757264c8: Include "Draft" revisions in Differential legacy status queries (authored by epriestley). · Explain WhyNov 7 2017, 11:35 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

differential/

constants/

DifferentialLegacyQuery.php

12 lines

Diff 45030

View Options

src/applications/differential/constants/DifferentialLegacyQuery.php

Include "Draft" revisions in Differential legacy status queriesClosedPublicActions