Page MenuHomePhabricator
Differential D18765

Include "Draft" revisions in Differential legacy status queries
ClosedPublic
Actions

Authored by epriestley on Nov 7 2017, 1:17 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Apr 25, 1:33 AM
Unknown Object (File)
Tue, Apr 23, 5:43 PM
Unknown Object (File)
Fri, Apr 19, 6:58 PM
Unknown Object (File)
Thu, Apr 11, 9:08 AM
Unknown Object (File)
Sat, Apr 6, 10:33 PM
Unknown Object (File)
Sat, Mar 30, 5:27 AM
Unknown Object (File)
Thu, Mar 28, 3:36 AM
Unknown Object (File)
Mar 13 2024, 4:47 AM
View All Files
Subscribers
None

Details

Reviewers
amckinley
Maniphest Tasks
T2543: Add a formal "Draft" / "Not Yet Ready for Review" state to Differential
Commits
rP759c757264c8: Include "Draft" revisions in Differential legacy status queries
Summary

See PHI199. Ref T2543. When you run a RevisionQuery with a legacy status constraint (via differential.query), we currently don't match "Draft" revisions.

Use the actual complete map from DifferentialRevisionStatus instead of hard coding the status list so "Draft" is included.

Test Plan
  • Ran differential.query with ids and status for a draft revision.
  • Before patch: revision not returned in results.
  • After patch: revision returned in results.

(Note that it returns as "Needs Review", for compatibility.)

Diff Detail

Repository
rP Phabricator
Branch
draft1
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 18808
Build 25353: Run Core Tests
Build 25352: arc lint + arc unit

Revision Contents
Changeset List

PathSize
src/
applications/
differential/
constants/
12 lines

Diff 45030

View Options

src/applications/differential/constants/DifferentialLegacyQuery.php

Loading...
Phabricator · Built by Phacility