Page MenuHomePhabricator
Differential D18765

Include "Draft" revisions in Differential legacy status queries
ClosedPublic
Actions

Authored by epriestley on Nov 7 2017, 1:17 PM.
Tags
None
Referenced Files
F18321727: D18765.id.diff
Sun, Aug 24, 5:09 PM
F18321484: D18765.diff
Sun, Aug 24, 4:57 PM
F18208184: D18765.id45030.diff
Mon, Aug 18, 8:14 PM
F18098865: D18765.diff
Fri, Aug 8, 11:26 PM
F18098801: D18765.id45030.diff
Fri, Aug 8, 11:08 PM
F18098304: D18765.id45036.diff
Fri, Aug 8, 7:29 PM
F18097407: D18765.id.diff
Fri, Aug 8, 1:10 PM
F18096071: D18765.id45030.diff
Fri, Aug 8, 4:15 AM
View All Files
Subscribers
None

Details

Reviewers
amckinley
Maniphest Tasks
T2543: Add a formal "Draft" / "Not Yet Ready for Review" state to Differential
Commits
rP759c757264c8: Include "Draft" revisions in Differential legacy status queries
Summary

See PHI199. Ref T2543. When you run a RevisionQuery with a legacy status constraint (via differential.query), we currently don't match "Draft" revisions.

Use the actual complete map from DifferentialRevisionStatus instead of hard coding the status list so "Draft" is included.

Test Plan
  • Ran differential.query with ids and status for a draft revision.
  • Before patch: revision not returned in results.
  • After patch: revision returned in results.

(Note that it returns as "Needs Review", for compatibility.)

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Revision Contents
Changeset List

PathSize
src/
applications/
differential/
constants/
12 lines

Diff 45036

View Options

src/applications/differential/constants/DifferentialLegacyQuery.php

Loading...
Phabricator · Built by Phacility