Page MenuHomePhabricator

Include "Draft" revisions in Differential legacy status queries
ClosedPublic

Authored by epriestley on Nov 7 2017, 1:17 PM.

Details

Summary

See PHI199. Ref T2543. When you run a RevisionQuery with a legacy status constraint (via differential.query), we currently don't match "Draft" revisions.

Use the actual complete map from DifferentialRevisionStatus instead of hard coding the status list so "Draft" is included.

Test Plan
  • Ran differential.query with ids and status for a draft revision.
  • Before patch: revision not returned in results.
  • After patch: revision returned in results.

(Note that it returns as "Needs Review", for compatibility.)

Diff Detail

Repository
rP Phabricator
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

epriestley created this revision.Nov 7 2017, 1:17 PM
epriestley requested review of this revision.Nov 7 2017, 1:18 PM
amckinley accepted this revision.Nov 7 2017, 9:10 PM
This revision is now accepted and ready to land.Nov 7 2017, 9:10 PM
This revision was automatically updated to reflect the committed changes.