Page MenuHomePhabricator
Differential D18765

Include "Draft" revisions in Differential legacy status queries
ClosedPublic
Actions

Authored by epriestley on Nov 7 2017, 1:17 PM.
Tags
None
Referenced Files
F15578802: D18765.id45030.diff
Tue, May 6, 9:01 PM
F15558320: D18765.id45036.diff
Tue, Apr 29, 2:11 AM
F15555136: D18765.id.diff
Mon, Apr 28, 10:02 AM
F15552375: D18765.diff
Sun, Apr 27, 8:38 PM
F15468255: D18765.id45030.diff
Apr 3 2025, 10:25 PM
F15452277: D18765.id45036.diff
Mar 29 2025, 3:29 AM
F15449626: D18765.id.diff
Mar 28 2025, 11:20 AM
F15447349: D18765.diff
Mar 27 2025, 11:16 PM
View All Files
Subscribers
None

Details

Reviewers
amckinley
Maniphest Tasks
T2543: Add a formal "Draft" / "Not Yet Ready for Review" state to Differential
Commits
rP759c757264c8: Include "Draft" revisions in Differential legacy status queries
Summary

See PHI199. Ref T2543. When you run a RevisionQuery with a legacy status constraint (via differential.query), we currently don't match "Draft" revisions.

Use the actual complete map from DifferentialRevisionStatus instead of hard coding the status list so "Draft" is included.

Test Plan
  • Ran differential.query with ids and status for a draft revision.
  • Before patch: revision not returned in results.
  • After patch: revision returned in results.

(Note that it returns as "Needs Review", for compatibility.)

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Revision Contents
Changeset List

PathSize
src/
applications/
differential/
constants/
12 lines

Diff 45036

View Options

src/applications/differential/constants/DifferentialLegacyQuery.php

Loading...
Phabricator · Built by Phacility