Page MenuHomePhabricator

Include "Draft" revisions in Differential legacy status queries
ClosedPublic

Authored by epriestley on Nov 7 2017, 1:17 PM.
Tags
None
Referenced Files
F15795152: D18765.id.diff
Fri, May 30, 10:07 AM
F15740748: D18765.diff
Thu, May 29, 8:47 PM
Unknown Object (File)
Sat, May 10, 1:32 AM
Unknown Object (File)
Tue, May 6, 9:01 PM
Unknown Object (File)
Apr 29 2025, 2:11 AM
Unknown Object (File)
Apr 28 2025, 10:02 AM
Unknown Object (File)
Apr 27 2025, 8:38 PM
Unknown Object (File)
Apr 3 2025, 10:25 PM
Subscribers
None

Details

Summary

See PHI199. Ref T2543. When you run a RevisionQuery with a legacy status constraint (via differential.query), we currently don't match "Draft" revisions.

Use the actual complete map from DifferentialRevisionStatus instead of hard coding the status list so "Draft" is included.

Test Plan
  • Ran differential.query with ids and status for a draft revision.
  • Before patch: revision not returned in results.
  • After patch: revision returned in results.

(Note that it returns as "Needs Review", for compatibility.)

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable