Page MenuHomePhabricator
Differential D18759

Fix some lint rendering issues when lines prior to other identical lines are removed
ClosedPublic
Actions

Authored by epriestley on Nov 1 2017, 7:35 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Aug 16, 12:01 AM
Unknown Object (File)
Tue, Aug 11, 7:50 AM
Unknown Object (File)
Jul 9 2026, 3:05 AM
Unknown Object (File)
Feb 17 2026, 7:44 PM
Unknown Object (File)
Feb 12 2026, 3:52 AM
Unknown Object (File)
Feb 2 2026, 1:48 AM
Unknown Object (File)
Nov 1 2025, 12:41 PM
Unknown Object (File)
Oct 31 2025, 10:15 PM
View All Files
Subscribers
None

Details

Reviewers
amckinley
Commits
rARC622862e04799: (stable) Promote 2017 Week 14
rARC90546042144f: Fix some lint rendering issues when lines prior to other identical lines are…
Summary

See PHI191. This is a rehash of an earlier fix, but we didn't have a test case for this half yet.

Test Plan
  • Added a failing test, made it pass.
  • Added a linter like the one in PHI191, ran it, got a valid lint result instead of an exception.

Diff Detail

Repository
rARC Arcanist
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Revision Contents
Changeset List

PathSize
src/
lint/
renderer/
47 lines
__tests__/
14 lines
data/
10 lines
4 lines
10 lines
4 lines

Diff 45021

View Options

src/lint/renderer/ArcanistConsoleLintRenderer.php

Loading...
View Options

src/lint/renderer/__tests__/ArcanistConsoleLintRendererTestCase.php

Loading...
View Options

src/lint/renderer/__tests__/data/rmmulti.expect

Loading...
View Options

src/lint/renderer/__tests__/data/rmmulti.txt

Loading...
View Options

src/lint/renderer/__tests__/data/rmmulti2.expect

Loading...
View Options

src/lint/renderer/__tests__/data/rmmulti2.txt

Loading...
Phabricator · Built by Phacility