Page MenuHomePhabricator
Differential D18747

Show small author portraits in Diffusion blame view
ClosedPublic
Actions

Authored by epriestley on Oct 31 2017, 6:32 PM.
Tags
None
Referenced Files
F15470470: D18747.diff
Fri, Apr 4, 10:40 PM
F15463636: D18747.id44996.diff
Wed, Apr 2, 1:44 AM
F15460957: D18747.id.diff
Tue, Apr 1, 3:44 AM
F15459316: D18747.id.diff
Mon, Mar 31, 11:52 AM
F15458456: D18747.id45002.diff
Mon, Mar 31, 3:19 AM
F15456939: D18747.diff
Sun, Mar 30, 1:12 PM
F15430297: D18747.diff
Mon, Mar 24, 6:57 AM
F15412315: D18747.id45002.diff
Wed, Mar 19, 12:24 PM
View All Files
Subscribers
None

Details

Reviewers
amckinley
Commits
rPbde71324f82b: Show small author portraits in Diffusion blame view
Summary

Depends on D18746. See PHI174. Adds small author portraits next to each blame line (this is similar to GitHub).

Test Plan

My local test data isn't that great since I don't have commits from a lot of accounts, but looks functional:

Screen Shot 2017-10-31 at 11.29.41 AM.png (296×291 px, 20 KB)

Diff Detail

Repository
rP Phabricator
Branch
blame2
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 18776
Build 25304: Run Core Tests
Build 25303: arc lint + arc unit

Event Timeline

epriestley created this revision.Oct 31 2017, 6:32 PM
Harbormaster completed remote builds in B18776: Diff 44996.Oct 31 2017, 6:33 PM
epriestley requested review of this revision.Oct 31 2017, 6:33 PM
amckinley accepted this revision.Oct 31 2017, 6:48 PM
This revision is now accepted and ready to land.Oct 31 2017, 6:48 PM
Closed by commit rPbde71324f82b: Show small author portraits in Diffusion blame view (authored by epriestley). · Explain WhyOct 31 2017, 7:10 PM
This revision was automatically updated to reflect the committed changes.
epriestley added a comment.Oct 31 2017, 7:19 PM

This is a bit funky with production data, I'll tweak it a little in a followup.

Revision Contents
Changeset List

PathSize
resources/
celerity/
4 lines
src/
applications/
diffusion/
controller/
49 lines
webroot/
rsrc/
css/
application/
diffusion/
12 lines

Diff 44996

View Options

resources/celerity/map.php

Loading...
View Options

src/applications/diffusion/controller/DiffusionBrowseController.php

Loading...
View Options

webroot/rsrc/css/application/diffusion/diffusion-source.css

Loading...
Phabricator · Built by Phacility