Page MenuHomePhabricator
Differential D18747

Show small author portraits in Diffusion blame view
ClosedPublic
Actions

Authored by epriestley on Oct 31 2017, 6:32 PM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Apr 19, 6:57 PM
Unknown Object (File)
Thu, Apr 11, 8:16 AM
Unknown Object (File)
Wed, Apr 3, 2:23 PM
Unknown Object (File)
Mar 27 2024, 2:41 PM
Unknown Object (File)
Mar 3 2024, 6:18 AM
Unknown Object (File)
Jan 31 2024, 3:53 PM
Unknown Object (File)
Jan 31 2024, 3:29 PM
Unknown Object (File)
Jan 25 2024, 12:45 AM
View All Files
Subscribers
None

Details

Reviewers
amckinley
Commits
rPbde71324f82b: Show small author portraits in Diffusion blame view
Summary

Depends on D18746. See PHI174. Adds small author portraits next to each blame line (this is similar to GitHub).

Test Plan

My local test data isn't that great since I don't have commits from a lot of accounts, but looks functional:

Screen Shot 2017-10-31 at 11.29.41 AM.png (296×291 px, 20 KB)

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley created this revision.Oct 31 2017, 6:32 PM
Harbormaster completed remote builds in B18776: Diff 44996.Oct 31 2017, 6:33 PM
epriestley requested review of this revision.Oct 31 2017, 6:33 PM
amckinley accepted this revision.Oct 31 2017, 6:48 PM
This revision is now accepted and ready to land.Oct 31 2017, 6:48 PM
Closed by commit rPbde71324f82b: Show small author portraits in Diffusion blame view (authored by epriestley). · Explain WhyOct 31 2017, 7:10 PM
This revision was automatically updated to reflect the committed changes.
epriestley added a comment.Oct 31 2017, 7:19 PM

This is a bit funky with production data, I'll tweak it a little in a followup.

Revision Contents
Changeset List

PathSize
resources/
celerity/
4 lines
src/
applications/
diffusion/
controller/
49 lines
webroot/
rsrc/
css/
application/
diffusion/
12 lines

Diff 45002

View Options

resources/celerity/map.php

Loading...
View Options

src/applications/diffusion/controller/DiffusionBrowseController.php

Loading...
View Options

webroot/rsrc/css/application/diffusion/diffusion-source.css

Loading...
Phabricator · Built by Phacility