Page MenuHomePhabricator

Revert changes to Diffusion blame view
ClosedPublic

Authored by epriestley on Oct 31 2017, 6:04 PM.
Tags
None
Referenced Files
F14402665: D18746.diff
Mon, Dec 23, 12:53 AM
Unknown Object (File)
Thu, Dec 12, 9:18 PM
Unknown Object (File)
Mon, Dec 9, 3:55 PM
Unknown Object (File)
Sun, Dec 1, 6:58 AM
Unknown Object (File)
Wed, Nov 27, 2:43 AM
Unknown Object (File)
Nov 17 2024, 9:47 AM
Unknown Object (File)
Oct 20 2024, 6:48 AM
Unknown Object (File)
Oct 20 2024, 6:48 AM
Subscribers
None

Details

Summary

Ref PHI174. This reverts most of these changes:

These changes made the Diffusion blame view very similar to GitHub's blame view. See D18452 for a before/after of the bulk of these changes; the other revisions are bugfixes.

I think this was generally a step backward, and not motivated by solving a specific problem. I've found the new UI less usable than the old one, and at least one install (see PHI174) also has.

In particular, the revision/commit titles are very bulky and not terribly useful; the date column also isn't terribly useful; the "age" color actually IS pretty useful and was heavily de-emphasized.

I've kept one bugfix here (missing 'a' tag type) and kept the upgraded icon for "Skip Past This Commit".

I'm going to follow this up with some additional changes:

  • Show a small author profile icon, similar to GitHub, to address PHI174 more directly.
  • Try a zebra-stripe on blocks of rows to make it more clear where changes affected by a particular commit begin and end.
  • Try a hue shift, not just a brightness/saturation shift, to make the "age" color more distinct.
  • Try computing colors as even steps, not based purely on age. Currently, if a file has one long-distant commit and several recent commits, all the recent ones show up as very bright green. I think this would probably be more useful if they were distributed more evenly across the available color bands.
Test Plan

Viewed blame views in Diffusion, saw a more compact UI similar to the old UI.

Screen Shot 2017-10-31 at 11.03.19 AM.png (266×766 px, 67 KB)

Diff Detail

Repository
rP Phabricator
Branch
blame1
Lint
Lint Passed
SeverityLocationCodeMessage
Advicesrc/applications/diffusion/controller/DiffusionBrowseController.php:1763XHP16TODO Comment
Unit
Tests Passed
Build Status
Buildable 18775
Build 25302: Run Core Tests
Build 25301: arc lint + arc unit