Page MenuHomePhabricator

Don't run Herald build rules when Differential revisions are updated automatically
ClosedPublic

Authored by epriestley on Oct 31 2017, 5:36 PM.
Tags
None
Referenced Files
F15380370: D18745.id44997.diff
Fri, Mar 14, 2:44 AM
Unknown Object (File)
Mon, Mar 3, 4:21 PM
Unknown Object (File)
Tue, Feb 25, 11:12 PM
Unknown Object (File)
Feb 10 2025, 10:17 PM
Unknown Object (File)
Feb 9 2025, 3:45 AM
Unknown Object (File)
Feb 9 2025, 12:44 AM
Unknown Object (File)
Feb 2 2025, 12:18 PM
Unknown Object (File)
Jan 30 2025, 5:47 AM
Subscribers
None

Details

Summary

Ref T2543. After D18731, Herald build rules run more often, but now incorrectly try to run builds when Diffusion closes a revision because a commit landed.

Test Plan

Made some mundane updates locally; this is tricky to test comprehensively locally so I'm mostly planning to just push it to secure.

Diff Detail

Repository
rP Phabricator
Branch
draft1
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 18774
Build 25300: Run Core Tests
Build 25299: arc lint + arc unit

Event Timeline

This revision is now accepted and ready to land.Oct 31 2017, 6:10 PM
This revision was automatically updated to reflect the committed changes.

I pushed this to secure so the next thing that lands should blow up if I got anything wrong.