Don't run Herald build rules when Differential revisions are updated automatically
ClosedPublic
Actions

Authored by epriestley on Oct 31 2017, 5:36 PM.

Details

Reviewers

amckinley

Maniphest Tasks

T2543: Add a formal "Draft" / "Not Yet Ready for Review" state to Differential

Commits

rP7fa0d066bc45: Don't run Herald build rules when Differential revisions are updated…

Summary

Ref T2543. After D18731, Herald build rules run more often, but now incorrectly try to run builds when Diffusion closes a revision because a commit landed.

Test Plan

Made some mundane updates locally; this is tricky to test comprehensively locally so I'm mostly planning to just push it to secure.

Diff Detail

Repository

rP Phabricator

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

epriestley created this revision.Oct 31 2017, 5:36 PM

Harbormaster completed remote builds in B18774: Diff 44994.Oct 31 2017, 5:37 PM

epriestley requested review of this revision.Oct 31 2017, 5:37 PM

amckinley accepted this revision.Oct 31 2017, 6:10 PM

This revision is now accepted and ready to land.Oct 31 2017, 6:10 PM

Closed by commit rP7fa0d066bc45: Don't run Herald build rules when Differential revisions are updated… (authored by epriestley). · Explain WhyOct 31 2017, 6:36 PM

This revision was automatically updated to reflect the committed changes.

I pushed this to secure so the next thing that lands should blow up if I got anything wrong.

Revision Contents
Changeset List

Path

Size

src/

applications/

differential/

editor/

DifferentialTransactionEditor.php

22 lines

herald/

DifferentialHeraldStateReasons.php

4 lines

Diff 44997

View Options

src/applications/differential/editor/DifferentialTransactionEditor.php