Paths

Table of Contentst

Differential D18729

Fix a couple of other missing getApplicationTransactionCommentObject() implementations
ClosedPublic
Actions

Authored by epriestley on Oct 24 2017, 12:59 PM.

Details

Reviewers

amckinley

Commits

rP28a24c333fdd: Fix a couple of other missing getApplicationTransactionCommentObject()…

Summary

See PHI165. See D18715. These objects (projects, blogs) also need implementations now.

(I thought about making this method abstract or doing try/catch to maybe make this more robust, but I think this should be the end of it, and those changes have mild complexity/compatibility/risk issues.)

Test Plan

Changed bin/search index to index only one document of each type, ran bin/search index --all --force, saw no more comment-related errors.

Diff Detail

Repository

rP Phabricator

Branch

index2

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 18738
Build 25247: Run Core Tests
Build 25246: arc lint + arc unit

Event Timeline

epriestley created this revision.Oct 24 2017, 12:59 PM

Harbormaster requested review of this revision.Oct 24 2017, 1:00 PM

Harbormaster completed remote builds in B18738: Diff 44958.

amckinley accepted this revision.Oct 24 2017, 3:44 PM

This revision is now accepted and ready to land.Oct 24 2017, 3:44 PM

Closed by commit rP28a24c333fdd: Fix a couple of other missing getApplicationTransactionCommentObject()… (authored by epriestley). · Explain WhyOct 24 2017, 4:05 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

phame/

storage/

PhameBlogTransaction.php

4 lines

project/

storage/

PhabricatorProjectTransaction.php

4 lines

Diff 44958

View Options

src/applications/phame/storage/PhameBlogTransaction.php