Differential D18727

Simplify UNION/ORDER query construction in DifferentialRevisionQuery
ClosedPublic
Actions

Authored by epriestley on Oct 23 2017, 10:01 PM.

Details

Reviewers

amckinley

Maniphest Tasks

T12680: Convert Audit to use UNION to improve the performance of the dashboard bucketing query

Commits

rP683df399e7f4: Simplify UNION/ORDER query construction in DifferentialRevisionQuery

Summary

Ref T12680. Use the slightly sleeker construction from D18722 in Differential.

Test Plan

Viewed revision list, reordered by date modified.

Diff Detail

Repository

rP Phabricator

Branch

dx1

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 18734
Build 25241: Run Core Tests
Build 25240: arc lint + arc unit

Event Timeline

epriestley created this revision.Oct 23 2017, 10:01 PM

Harbormaster requested review of this revision.Oct 23 2017, 10:01 PM

Harbormaster completed remote builds in B18734: Diff 44954.

epriestley edited the test plan for this revision. (Show Details)Oct 23 2017, 10:06 PM

amckinley accepted this revision.Oct 23 2017, 11:00 PM

This revision is now accepted and ready to land.Oct 23 2017, 11:00 PM

Closed by commit rP683df399e7f4: Simplify UNION/ORDER query construction in DifferentialRevisionQuery (authored by epriestley). · Explain WhyOct 23 2017, 11:17 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

differential/

query/

DifferentialRevisionQuery.php

16 lines

Diff 44954

View Options

src/applications/differential/query/DifferentialRevisionQuery.php

Simplify UNION/ORDER query construction in DifferentialRevisionQueryClosedPublicActions