Start revisions in "Draft" if prototypes are enabled
ClosedPublic
Actions

Authored by epriestley on Oct 19 2017, 8:37 PM.

Tags

None

Referenced Files

	F15464837: D18713.id44928.diff
	Wed, Apr 2, 12:53 PM

	F15462264: D18713.id44928.diff
	Tue, Apr 1, 1:31 PM

	F15460534: D18713.id44925.diff
	Mon, Mar 31, 11:40 PM

	F15452800: D18713.diff
	Sat, Mar 29, 7:20 AM

	F15449584: D18713.id.diff
	Fri, Mar 28, 11:06 AM

	F15449357: D18713.id44928.diff
	Fri, Mar 28, 9:41 AM

	F15448738: D18713.id.diff
	Fri, Mar 28, 6:41 AM

	F15446885: D18713.diff
	Thu, Mar 27, 8:38 PM

View All Files

Subscribers

None

Details

Reviewers

amckinley

Maniphest Tasks

T2543: Add a formal "Draft" / "Not Yet Ready for Review" state to Differential

Commits

rPbfabe49c5ae8: Start revisions in "Draft" if prototypes are enabled

Summary

Ref T2543. This is a less ambitious version of the rule in D18628, which I backed off from, since I think this probably still has a fair number of loose ends to tie up.

Test Plan

Created a revision locally.

Diff Detail

Repository

rP Phabricator

Branch

draft1

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 18703
Build 25196: Run Core Tests
Build 25195: arc lint + arc unit

Event Timeline

epriestley created this revision.Oct 19 2017, 8:37 PM

Harbormaster completed remote builds in B18703: Diff 44925.Oct 19 2017, 8:38 PM

epriestley edited the summary of this revision. (Show Details)Oct 19 2017, 8:38 PM

amckinley accepted this revision.Oct 19 2017, 9:20 PM

This revision is now accepted and ready to land.Oct 19 2017, 9:20 PM

Closed by commit rPbfabe49c5ae8: Start revisions in "Draft" if prototypes are enabled (authored by epriestley). · Explain WhyOct 20 2017, 3:40 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

differential/

storage/

DifferentialRevision.php

8 lines

Diff 44925

View Options

src/applications/differential/storage/DifferentialRevision.php

Start revisions in "Draft" if prototypes are enabledClosedPublicActions