Page MenuHomePhabricator

Create revisions into "Draft", publish them when builds finish
ClosedPublic

Authored by epriestley on Sep 18 2017, 11:01 PM.
Tags
None
Referenced Files
F18717905: D18628.id44740.diff
Mon, Sep 29, 2:39 PM
F18648502: D18628.diff
Sat, Sep 20, 12:34 PM
F18627856: D18628.diff
Tue, Sep 16, 4:57 AM
F18597803: D18628.id.diff
Sat, Sep 13, 3:42 AM
F18509120: D18628.id.diff
Fri, Sep 5, 3:14 AM
F18501662: D18628.diff
Thu, Sep 4, 9:53 PM
F18350943: D18628.diff
Aug 26 2025, 8:42 PM
F18099415: D18628.id44723.diff
Aug 9 2025, 4:43 AM
Subscribers
None

Details

Summary

Ref T2543. This doesn't stand alone since mail still goes out normally, but gets this piece working: new revisions start as "Draft", then after updates if there are no builds they go into "Needs Review".

This should work in general because builds update revisions when they complete, to publish a "Harbormaster finished build yada yada" transaction. So either we'll un-draft immediately, or un-draft after the last build finishes.

I'll hold this until the mail and some other stuff (like UI hints) are in slightly better shape since I think it's probably too rough on its own.

Test Plan

Created revisions locally, saw them un-draft after builds.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable