Page MenuHomePhabricator

Create revisions into "Draft", publish them when builds finish
ClosedPublic

Authored by epriestley on Sep 18 2017, 11:01 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Jun 29, 8:40 AM
Unknown Object (File)
Sat, Jun 28, 1:07 PM
Unknown Object (File)
Fri, Jun 27, 9:33 AM
Unknown Object (File)
Fri, Jun 27, 9:02 AM
Unknown Object (File)
May 31 2025, 8:56 PM
Unknown Object (File)
May 25 2025, 6:53 AM
Unknown Object (File)
May 7 2025, 6:01 PM
Unknown Object (File)
May 5 2025, 4:35 AM
Subscribers
None

Details

Summary

Ref T2543. This doesn't stand alone since mail still goes out normally, but gets this piece working: new revisions start as "Draft", then after updates if there are no builds they go into "Needs Review".

This should work in general because builds update revisions when they complete, to publish a "Harbormaster finished build yada yada" transaction. So either we'll un-draft immediately, or un-draft after the last build finishes.

I'll hold this until the mail and some other stuff (like UI hints) are in slightly better shape since I think it's probably too rough on its own.

Test Plan

Created revisions locally, saw them un-draft after builds.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable