Page MenuHomePhabricator

Create revisions into "Draft", publish them when builds finish
ClosedPublic

Authored by epriestley on Sep 18 2017, 11:01 PM.
Tags
None
Referenced Files
F15582766: D18628.id44740.diff
Wed, May 7, 6:01 PM
F15571174: D18628.diff
Mon, May 5, 4:35 AM
F15570890: D18628.id44723.diff
Sun, May 4, 11:02 PM
F15565637: D18628.diff
Thu, May 1, 5:55 AM
F15564086: D18628.id44723.diff
Wed, Apr 30, 10:55 AM
F15562609: D18628.id44722.diff
Wed, Apr 30, 3:26 AM
F15560704: D18628.id44740.diff
Tue, Apr 29, 4:10 PM
F15554755: D18628.id.diff
Mon, Apr 28, 8:23 AM
Subscribers
None

Details

Summary

Ref T2543. This doesn't stand alone since mail still goes out normally, but gets this piece working: new revisions start as "Draft", then after updates if there are no builds they go into "Needs Review".

This should work in general because builds update revisions when they complete, to publish a "Harbormaster finished build yada yada" transaction. So either we'll un-draft immediately, or un-draft after the last build finishes.

I'll hold this until the mail and some other stuff (like UI hints) are in slightly better shape since I think it's probably too rough on its own.

Test Plan

Created revisions locally, saw them un-draft after builds.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable