Page MenuHomePhabricator

Create revisions into "Draft", publish them when builds finish
ClosedPublic

Authored by epriestley on Sep 18 2017, 11:01 PM.

Details

Summary

Ref T2543. This doesn't stand alone since mail still goes out normally, but gets this piece working: new revisions start as "Draft", then after updates if there are no builds they go into "Needs Review".

This should work in general because builds update revisions when they complete, to publish a "Harbormaster finished build yada yada" transaction. So either we'll un-draft immediately, or un-draft after the last build finishes.

I'll hold this until the mail and some other stuff (like UI hints) are in slightly better shape since I think it's probably too rough on its own.

Test Plan

Created revisions locally, saw them un-draft after builds.

Diff Detail

Repository
rP Phabricator
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

epriestley created this revision.Sep 18 2017, 11:01 PM
amckinley accepted this revision.Sep 18 2017, 11:51 PM
This revision is now accepted and ready to land.Sep 18 2017, 11:51 PM
epriestley updated this revision to Diff 44723.Sep 19 2017, 4:19 PM
  • Actually, don't start revisions as drafts yet, so this can land without changing any behavior.
This revision was automatically updated to reflect the committed changes.