Page MenuHomePhabricator

Tweak rate limiting point counts for omnipotent users
ClosedPublic

Authored by epriestley on Oct 14 2017, 3:00 PM.
Tags
None
Referenced Files
F15443501: D18708.id.diff
Thu, Mar 27, 4:43 AM
F15441207: D18708.diff
Wed, Mar 26, 4:55 PM
F15417644: D18708.id44914.diff
Thu, Mar 20, 5:45 PM
F15391610: D18708.id44913.diff
Sat, Mar 15, 10:44 AM
F15391326: D18708.id44913.diff
Sat, Mar 15, 9:24 AM
F15334161: D18708.id.diff
Mar 8 2025, 7:11 AM
Unknown Object (File)
Feb 9 2025, 4:47 AM
Unknown Object (File)
Feb 9 2025, 4:47 AM
Subscribers
None

Details

Summary

Ref T13008. We haven't hit any issues with this, but I can imagine we might in the future.

When one host makes an intracluster request to another host, the $viewer ends up as the omnipotent viewer. This viewer isn't logged in, so they'll currently accumulate rate limit points at a high rate.

Instead, don't give them any points. These requests are always legitimate, and if they originated from a user request, that request should be the one getting rate limited.

Test Plan

Browsed around.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable