Page MenuHomePhabricator

Tweak rate limiting point counts for omnipotent users
ClosedPublic

Authored by epriestley on Oct 14 2017, 3:00 PM.
Tags
None
Referenced Files
F18902524: D18708.id.diff
Sat, Nov 8, 1:36 AM
F18772450: D18708.diff
Oct 9 2025, 2:39 AM
F18763993: D18708.id.diff
Oct 7 2025, 3:31 AM
F18761560: D18708.diff
Oct 6 2025, 3:09 PM
F18753597: D18708.id44913.diff
Oct 4 2025, 7:35 PM
F18647768: D18708.diff
Sep 19 2025, 2:53 PM
F18566422: D18708.id.diff
Sep 9 2025, 2:36 PM
F18501739: D18708.diff
Sep 4 2025, 9:56 PM
Subscribers
None

Details

Summary

Ref T13008. We haven't hit any issues with this, but I can imagine we might in the future.

When one host makes an intracluster request to another host, the $viewer ends up as the omnipotent viewer. This viewer isn't logged in, so they'll currently accumulate rate limit points at a high rate.

Instead, don't give them any points. These requests are always legitimate, and if they originated from a user request, that request should be the one getting rate limited.

Test Plan

Browsed around.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable