In "Move Tasks to Column...", show only visible columns
ClosedPublic
Actions

Authored by epriestley on Oct 2 2017, 6:38 PM.

Details

Reviewers

Commits

rP4390a274c1d8: (stable) In "Move Tasks to Column...", show only visible columns
rPf9110b87abf3: In "Move Tasks to Column...", show only visible columns

Summary

See PHI94. I considered this initially but wasn't sure about it. However, PHI94 brings up the good point that we already use a similar rule in Maniphest.

For consistency, only show visible columns here too.

Test Plan

Used "Move tasks to column..." on a board with visible and hidden columns, only saw visbile columns offered in the dropdown.

Diff Detail

Repository

rP Phabricator

Branch

hidecol1

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 18603
Build 25058: Run Core Tests
Build 25057: arc lint + arc unit

Event Timeline

epriestley created this revision.Oct 2 2017, 6:38 PM

Harbormaster completed remote builds in B18603: Diff 44821.Oct 2 2017, 6:39 PM

amckinley accepted this revision.Oct 2 2017, 6:40 PM

This revision is now accepted and ready to land.Oct 2 2017, 6:40 PM

Closed by commit rPf9110b87abf3: In "Move Tasks to Column...", show only visible columns (authored by epriestley). · Explain WhyOct 2 2017, 6:41 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

project/

controller/

PhabricatorProjectBoardViewController.php

6 lines

Diff 44821

View Options

src/applications/project/controller/PhabricatorProjectBoardViewController.php

In "Move Tasks to Column...", show only visible columnsClosedPublicActions