Page MenuHomePhabricator

Allow filename for linter tests to be explicitly specified
Needs ReviewPublic

Authored by joshuaspence on Sep 27 2017, 5:14 AM.

Details

Reviewers
epriestley
Group Reviewers
Blessed Reviewers
Summary

Currently the temporary file created for testing linters is always named the same as the *.lint-test file which specifies the test case. Unfortunately, some linters (in my case, TSLint) refuse to lint a file unless it has a specific file extension. This diff allows *.lint-test test cases to explicitly specify a filename for this purpose.

Test Plan

Tested with our custom TSLint linter.

Diff Detail

Repository
rARC Arcanist
Branch
master
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 18548
Build 24989: Run Core Tests
Build 24988: arc lint + arc unit