Page MenuHomePhabricator
Differential D18643

Remove "arc lint --cache"
ClosedPublic
Actions

Authored by epriestley on Sep 25 2017, 6:22 PM.
Tags
None
Referenced Files
F14488573: D18643.diff
Wed, Jan 1, 2:32 PM
Unknown Object (File)
Thu, Dec 19, 12:38 AM
Unknown Object (File)
Tue, Dec 17, 4:21 AM
Unknown Object (File)
Mon, Dec 16, 4:46 PM
Unknown Object (File)
Sun, Dec 15, 12:52 AM
Unknown Object (File)
Fri, Dec 13, 9:52 PM
Unknown Object (File)
Sun, Dec 8, 9:42 PM
Unknown Object (File)
Thu, Dec 5, 2:14 PM
View All Files
Subscribers
joshuaspence

Details

Reviewers
amckinley
Maniphest Tasks
T12996: Parallelize substages of `arc diff`
Commits
rARCbe7987b25a82: Remove "arc lint --cache"
Summary

Ref T12996. This is another half-baked Facebook-specific feature. Clear it out of the way so arc lint can be modernized more easily.

Test Plan

Grepped for cache, created this revision.

Diff Detail

Repository
rARC Arcanist
Branch
ll4
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 18536
Build 24967: Run Core Tests
Build 24966: arc lint + arc unit

Event Timeline

epriestley created this revision.Sep 25 2017, 6:22 PM
Harbormaster completed remote builds in B18536: Diff 44758.Sep 25 2017, 6:22 PM
amckinley accepted this revision.Sep 25 2017, 6:30 PM
This revision is now accepted and ready to land.Sep 25 2017, 6:30 PM
Closed by commit rARCbe7987b25a82: Remove "arc lint --cache" (authored by epriestley). · Explain WhySep 27 2017, 3:21 PM
This revision was automatically updated to reflect the committed changes.
epriestley mentioned this in D18651: Make "arc diff" sort of detect dependent revisions.Sep 27 2017, 5:05 PM
epriestley mentioned this in rARC5ddc5732239a: Make "arc diff" sort of detect dependent revisions.Sep 27 2017, 5:46 PM
joshuaspence added a subscriber: joshuaspence.Apr 8 2018, 12:48 AM

There's still a bunch of logic in ArcanistLintEngine and ArcanistLintEngine regarding caching... should that be removed/deprecated as well?

epriestley added a comment.Apr 8 2018, 12:50 AM

Yeah. I think granularity on lint messages gets a mention in T13098, at least. I don't currently plan to rebuild support for this stuff, at least until all the dust has settled on the whole huge tree of issues under T13098.

Revision Contents
Changeset List

PathSize
src/
configuration/
13 lines
workflow/
100 lines

Diff 44758

View Options

src/configuration/ArcanistSettings.php

Loading...
View Options

src/workflow/ArcanistLintWorkflow.php

Loading...
Phabricator · Built by Phacility