Page MenuHomePhabricator
Differential D18639

Fix node for nullable return value
ClosedPublic
Actions

Authored by joshuaspence on Sep 25 2017, 5:32 AM.
Tags
None
Referenced Files
F15463026: D18639.id45073.diff
Tue, Apr 1, 7:52 PM
F15435028: D18639.id45073.diff
Tue, Mar 25, 6:32 AM
F15420496: D18639.id45073.diff
Fri, Mar 21, 2:26 PM
F15420495: D18639.id45073.diff
Fri, Mar 21, 2:26 PM
F15420417: D18639.id44754.diff
Fri, Mar 21, 1:55 PM
F15420416: D18639.id44754.diff
Fri, Mar 21, 1:55 PM
F15420402: D18639.diff
Fri, Mar 21, 1:48 PM
F15420401: D18639.diff
Fri, Mar 21, 1:48 PM
View All Files
Subscribers
Firehed
Korvin
wjiang

Details

Reviewers
epriestley
Group Reviewers
Blessed Reviewers
Maniphest Tasks
T4334: Support PHP5.4+ syntax in XHPAST
Commits
rPHUae80e72461d2: Fix node for nullable return value
Summary

Ref T4334. Fixes a bug introduced by D18621 which created a node without a valid type.

Test Plan

N/A

Diff Detail

Repository
rPHU libphutil
Branch
master
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 18532
Build 24959: Run Core Tests
Build 24958: arc lint + arc unit

Revision Contents
Changeset List

PathSize
src/
parser/
xhpast/
__tests__/
data/
10 lines
bin/
2 lines
support/
xhpast/
2 lines
2 lines
2 lines

Diff 44754

View Options

src/parser/xhpast/__tests__/data/return-type.php.test

Loading...
View Options

src/parser/xhpast/bin/PhutilXHPASTBinary.php

Loading...
View Options

support/xhpast/parser.y

Loading...
View Options

support/xhpast/parser.yacc.cpp

Loading...
View Options

support/xhpast/xhpast.cpp

Loading...
Phabricator · Built by Phacility