Differential D18639

Fix node for nullable return value
ClosedPublic
Actions

Authored by joshuaspence on Sep 25 2017, 5:32 AM.

Details

Reviewers

epriestley

Group Reviewers

Blessed Reviewers

Maniphest Tasks

T4334: Support PHP5.4+ syntax in XHPAST

Commits

rPHUae80e72461d2: Fix node for nullable return value

Summary

Ref T4334. Fixes a bug introduced by D18621 which created a node without a valid type.

Test Plan

N/A

Diff Detail

Repository

rPHU libphutil

Branch

master

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 18532
Build 24959: Run Core Tests
Build 24958: arc lint + arc unit

Event Timeline

joshuaspence created this revision.Sep 25 2017, 5:32 AM

Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptSep 25 2017, 5:32 AM

Herald added subscribers: Firehed, Korvin. · View Herald Transcript

Harbormaster completed remote builds in B18532: Diff 44754.Sep 25 2017, 5:33 AM

epriestley accepted this revision.Sep 25 2017, 1:26 PM

This revision is now accepted and ready to land.Sep 25 2017, 1:26 PM

Closed by commit rPHUae80e72461d2: Fix node for nullable return value (authored by joshuaspence). · Explain WhyNov 24 2017, 3:27 AM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

parser/

xhpast/

__tests__/

data/

return-type.php.test

10 lines

bin/

PhutilXHPASTBinary.php

2 lines

support/

xhpast/

parser.y

2 lines

parser.yacc.cpp

2 lines

xhpast.cpp

2 lines

Diff 44754

View Options

src/parser/xhpast/tests/data/return-type.php.test

View Options

src/parser/xhpast/bin/PhutilXHPASTBinary.php

View Options

support/xhpast/parser.y

View Options

support/xhpast/parser.yacc.cpp

View Options

Fix node for nullable return valueClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 44754

src/parser/xhpast/__tests__/data/return-type.php.test

src/parser/xhpast/bin/PhutilXHPASTBinary.php

support/xhpast/parser.y

support/xhpast/parser.yacc.cpp

support/xhpast/xhpast.cpp

Fix node for nullable return value
ClosedPublic
Actions

Revision Contents
Changeset List

src/parser/xhpast/tests/data/return-type.php.test