Page MenuHomePhabricator

Improve search highlighting for CJK and substring queries
ClosedPublic

Authored by epriestley on Sep 22 2017, 3:15 PM.
Tags
None
Referenced Files
F18764555: D18635.diff
Tue, Oct 7, 6:36 AM
F18757446: D18635.id44742.diff
Sun, Oct 5, 5:28 PM
F18755007: D18635.id44745.diff
Sun, Oct 5, 3:05 AM
F18670642: D18635.id44745.diff
Thu, Sep 25, 12:58 AM
F18643685: D18635.diff
Fri, Sep 19, 3:01 AM
F18600399: D18635.diff
Sat, Sep 13, 9:39 AM
F18368701: D18635.id44745.diff
Aug 28 2025, 1:21 AM
F18194279: D18635.id44742.diff
Aug 17 2025, 9:15 AM
Subscribers
None

Details

Summary

Fixes T12995. Currently, the result highlighter (which shows where terms matched) only works in "term" mode, not in "substring" mode.

Provide better feedback and behvaior:

  • When a term is a substring term, color it a little differently and add a tooltip. (This is partly to make it easier to debug/diagnose things, probably not enormously valuable to users.)
  • When a term is a substring term, highlight it anywhere in the results.
Test Plan

Queried for latin and CJK terms.

Here is CJK being highlighted:

Screen Shot 2017-09-22 at 8.08.26 AM.png (661×550 px, 56 KB)

Here is substring vs non-substring implicit behavior:

Screen Shot 2017-09-22 at 8.08.34 AM.png (490×515 px, 36 KB)

Here's ONLY terms being highlighted:

Screen Shot 2017-09-22 at 8.09.57 AM.png (570×523 px, 51 KB)

Here's terms and substrings, since the query now has a substring:

Screen Shot 2017-09-22 at 8.10.01 AM.png (579×539 px, 54 KB)

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Looks good (minus nit), assuming lint is a false positive.

src/applications/search/view/PhabricatorSearchResultView.php
130

"correctly"

This revision is now accepted and ready to land.Sep 22 2017, 6:08 PM
  • Use more conventional grammar.
This revision was automatically updated to reflect the committed changes.