Page MenuHomePhabricator

Align most revision actions to the new "Draft" state
ClosedPublic

Authored by epriestley on Sep 18 2017, 9:17 PM.
Tags
None
Referenced Files
F15737365: D18626.diff
Thu, May 29, 5:54 PM
Unknown Object (File)
Mon, May 5, 4:35 AM
Unknown Object (File)
Apr 26 2025, 2:07 PM
Unknown Object (File)
Apr 26 2025, 12:03 PM
Unknown Object (File)
Apr 25 2025, 5:25 PM
Unknown Object (File)
Apr 21 2025, 7:25 PM
Unknown Object (File)
Mar 30 2025, 6:25 PM
Unknown Object (File)
Mar 25 2025, 4:13 PM
Subscribers
None

Details

Summary

Ref T2543. Most actions are not available for drafts.

Authors can "Request Review" (move out of draft to become a normal revision) or "Abandon".

Non-authors can't do anything (maybe we'll let them do something later -- like "Commandeer"? -- if there's a good reason).

Test Plan

Viewed a draft revision as an author and non-author, saw fewer actions available.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

amckinley added inline comments.
src/applications/differential/xaction/DifferentialRevisionCommandeerTransaction.php
69–73

What's the reasoning for this constraint? A "draft" revision will definitely have more activity in the future, so commandeering is always premature?

This revision is now accepted and ready to land.Sep 18 2017, 11:55 PM
src/applications/differential/xaction/DifferentialRevisionCommandeerTransaction.php
69–73

Mostly just to make the logic easier to write for now. I think we'll probably allow this eventually, but I'm not sure anyone will really need it.

This revision was automatically updated to reflect the committed changes.