Page MenuHomePhabricator

Align most revision actions to the new "Draft" state
ClosedPublic

Authored by epriestley on Sep 18 2017, 9:17 PM.
Tags
None
Referenced Files
F18509118: D18626.id.diff
Fri, Sep 5, 3:14 AM
F18501657: D18626.diff
Thu, Sep 4, 9:53 PM
F18220289: D18626.id.diff
Tue, Aug 19, 2:23 PM
F18207346: D18626.diff
Mon, Aug 18, 5:47 PM
F17842918: D18626.id44738.diff
Jul 27 2025, 12:16 AM
F17820058: D18626.diff
Jul 26 2025, 1:45 AM
F17803732: D18626.id.diff
Jul 25 2025, 10:32 AM
F17798881: D18626.id44738.diff
Jul 25 2025, 4:13 AM
Subscribers
None

Details

Summary

Ref T2543. Most actions are not available for drafts.

Authors can "Request Review" (move out of draft to become a normal revision) or "Abandon".

Non-authors can't do anything (maybe we'll let them do something later -- like "Commandeer"? -- if there's a good reason).

Test Plan

Viewed a draft revision as an author and non-author, saw fewer actions available.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

amckinley added inline comments.
src/applications/differential/xaction/DifferentialRevisionCommandeerTransaction.php
69–73

What's the reasoning for this constraint? A "draft" revision will definitely have more activity in the future, so commandeering is always premature?

This revision is now accepted and ready to land.Sep 18 2017, 11:55 PM
src/applications/differential/xaction/DifferentialRevisionCommandeerTransaction.php
69–73

Mostly just to make the logic easier to write for now. I think we'll probably allow this eventually, but I'm not sure anyone will really need it.

This revision was automatically updated to reflect the committed changes.