Page MenuHomePhabricator

Align most revision actions to the new "Draft" state
ClosedPublic

Authored by epriestley on Sep 18 2017, 9:17 PM.
Tags
None
Referenced Files
F19922457: D18626.id44738.diff
Mon, Apr 6, 6:33 PM
F19550120: D18626.diff
Jan 27 2026, 6:01 PM
F19550119: D18626.diff
Jan 27 2026, 6:01 PM
F19305372: D18626.id44720.diff
Dec 24 2025, 4:42 PM
F19275532: D18626.diff
Dec 23 2025, 12:36 AM
F19203730: D18626.id44738.diff
Dec 16 2025, 6:23 PM
F19069747: D18626.id.diff
Nov 30 2025, 3:02 PM
F19063082: D18626.diff
Nov 29 2025, 5:45 PM
Subscribers
None

Details

Summary

Ref T2543. Most actions are not available for drafts.

Authors can "Request Review" (move out of draft to become a normal revision) or "Abandon".

Non-authors can't do anything (maybe we'll let them do something later -- like "Commandeer"? -- if there's a good reason).

Test Plan

Viewed a draft revision as an author and non-author, saw fewer actions available.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

amckinley added inline comments.
src/applications/differential/xaction/DifferentialRevisionCommandeerTransaction.php
69–73

What's the reasoning for this constraint? A "draft" revision will definitely have more activity in the future, so commandeering is always premature?

This revision is now accepted and ready to land.Sep 18 2017, 11:55 PM
src/applications/differential/xaction/DifferentialRevisionCommandeerTransaction.php
69–73

Mostly just to make the logic easier to write for now. I think we'll probably allow this eventually, but I'm not sure anyone will really need it.

This revision was automatically updated to reflect the committed changes.