Page MenuHomePhabricator

Align most revision actions to the new "Draft" state
ClosedPublic

Authored by epriestley on Sep 18 2017, 9:17 PM.
Tags
None
Referenced Files
F18843909: D18626.id44738.diff
Wed, Oct 29, 1:50 AM
F18833179: D18626.diff
Sun, Oct 26, 1:14 AM
F18831960: D18626.diff
Sat, Oct 25, 5:44 PM
F18766534: D18626.id.diff
Tue, Oct 7, 5:11 PM
F18749425: D18626.diff
Sat, Oct 4, 3:52 AM
F18606376: D18626.diff
Sep 13 2025, 10:13 PM
F18509118: D18626.id.diff
Sep 5 2025, 3:14 AM
F18501657: D18626.diff
Sep 4 2025, 9:53 PM
Subscribers
None

Details

Summary

Ref T2543. Most actions are not available for drafts.

Authors can "Request Review" (move out of draft to become a normal revision) or "Abandon".

Non-authors can't do anything (maybe we'll let them do something later -- like "Commandeer"? -- if there's a good reason).

Test Plan

Viewed a draft revision as an author and non-author, saw fewer actions available.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

amckinley added inline comments.
src/applications/differential/xaction/DifferentialRevisionCommandeerTransaction.php
69–73

What's the reasoning for this constraint? A "draft" revision will definitely have more activity in the future, so commandeering is always premature?

This revision is now accepted and ready to land.Sep 18 2017, 11:55 PM
src/applications/differential/xaction/DifferentialRevisionCommandeerTransaction.php
69–73

Mostly just to make the logic easier to write for now. I think we'll probably allow this eventually, but I'm not sure anyone will really need it.

This revision was automatically updated to reflect the committed changes.