Page MenuHomePhabricator

Align most revision actions to the new "Draft" state
ClosedPublic

Authored by epriestley on Sep 18 2017, 9:17 PM.
Tags
None
Referenced Files
F15457751: D18626.id44738.diff
Sun, Mar 30, 6:25 PM
F15436723: D18626.id.diff
Tue, Mar 25, 4:13 PM
F15432808: D18626.diff
Mon, Mar 24, 7:41 PM
F15425159: D18626.diff
Sun, Mar 23, 2:48 AM
F15416407: D18626.id44720.diff
Thu, Mar 20, 10:55 AM
F15412509: D18626.id44738.diff
Wed, Mar 19, 1:22 PM
F15335505: D18626.diff
Sat, Mar 8, 4:03 PM
F15334394: D18626.diff
Sat, Mar 8, 8:45 AM
Subscribers
None

Details

Summary

Ref T2543. Most actions are not available for drafts.

Authors can "Request Review" (move out of draft to become a normal revision) or "Abandon".

Non-authors can't do anything (maybe we'll let them do something later -- like "Commandeer"? -- if there's a good reason).

Test Plan

Viewed a draft revision as an author and non-author, saw fewer actions available.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

amckinley added inline comments.
src/applications/differential/xaction/DifferentialRevisionCommandeerTransaction.php
69–73

What's the reasoning for this constraint? A "draft" revision will definitely have more activity in the future, so commandeering is always premature?

This revision is now accepted and ready to land.Sep 18 2017, 11:55 PM
src/applications/differential/xaction/DifferentialRevisionCommandeerTransaction.php
69–73

Mostly just to make the logic easier to write for now. I think we'll probably allow this eventually, but I'm not sure anyone will really need it.

This revision was automatically updated to reflect the committed changes.