Page MenuHomePhabricator

Align most revision actions to the new "Draft" state
ClosedPublic

Authored by epriestley on Sep 18 2017, 9:17 PM.
Tags
None
Referenced Files
F13078771: D18626.id44738.diff
Tue, Apr 23, 6:43 PM
F13078770: D18626.id44720.diff
Tue, Apr 23, 6:43 PM
F13078769: D18626.id.diff
Tue, Apr 23, 6:43 PM
F13078767: D18626.diff
Tue, Apr 23, 6:42 PM
Unknown Object (File)
Sat, Apr 20, 10:58 AM
Unknown Object (File)
Fri, Apr 19, 6:49 PM
Unknown Object (File)
Sat, Apr 13, 8:48 PM
Unknown Object (File)
Thu, Apr 11, 9:10 AM
Subscribers
None

Details

Summary

Ref T2543. Most actions are not available for drafts.

Authors can "Request Review" (move out of draft to become a normal revision) or "Abandon".

Non-authors can't do anything (maybe we'll let them do something later -- like "Commandeer"? -- if there's a good reason).

Test Plan

Viewed a draft revision as an author and non-author, saw fewer actions available.

Diff Detail

Repository
rP Phabricator
Branch
draft2
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 18496
Build 24907: Run Core Tests
Build 24906: arc lint + arc unit

Event Timeline

amckinley added inline comments.
src/applications/differential/xaction/DifferentialRevisionCommandeerTransaction.php
69–73

What's the reasoning for this constraint? A "draft" revision will definitely have more activity in the future, so commandeering is always premature?

This revision is now accepted and ready to land.Sep 18 2017, 11:55 PM
src/applications/differential/xaction/DifferentialRevisionCommandeerTransaction.php
69–73

Mostly just to make the logic easier to write for now. I think we'll probably allow this eventually, but I'm not sure anyone will really need it.

This revision was automatically updated to reflect the committed changes.