Page MenuHomePhabricator

Pass HGPLAIN in the environment when testing "hg" version
ClosedPublic

Authored by epriestley on Sep 15 2017, 12:43 PM.
Tags
None
Referenced Files
F14153211: D18610.diff
Thu, Dec 5, 2:25 AM
Unknown Object (File)
Tue, Dec 3, 11:56 AM
Unknown Object (File)
Mon, Dec 2, 11:46 AM
Unknown Object (File)
Wed, Nov 20, 4:51 AM
Unknown Object (File)
Wed, Nov 6, 12:06 AM
Unknown Object (File)
Wed, Nov 6, 12:06 AM
Unknown Object (File)
Wed, Nov 6, 12:06 AM
Unknown Object (File)
Nov 4 2024, 10:34 AM
Subscribers
None

Details

Summary

See T12972. In Phabricator, we always execute with HGPLAIN but this didn't make it into the standalone binary analyzer:

https://secure.phabricator.com/source/phabricator/browse/master/src/applications/diffusion/protocol/DiffusionMercurialCommandEngine.php;c71cb944a42851de00b2129f15899f7681b0f7ed$31

HGPLAIN disables translations and extensions which may make hg version do something unexpected.

Test Plan

Verified my local version of Mercurial is still identified correctly in Config. I have yet to figure out how to install non-English Mercurial so I didn't truly test this, but our use of HGPLAIN in other contexts is well-established.

Diff Detail

Repository
rPHU libphutil
Branch
plain1
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 18460
Build 24858: Run Core Tests
Build 24857: arc lint + arc unit