Page MenuHomePhabricator
Differential D18526

Update Settings for WHITE_CONFIG style boxes
ClosedPublic
Actions

Authored by chad on Sep 4 2017, 7:59 PM.
Tags
None
Referenced Files
F22793432: D18526.id44529.diff
Tue, Oct 6, 11:53 PM
F22744082: D18526.id44529.diff
Sun, Oct 4, 3:55 PM
F22738853: D18526.id44493.diff
Sun, Oct 4, 12:00 PM
F22709883: D18526.id44531.diff
Sat, Oct 3, 11:31 AM
F22676744: D18526.diff
Thu, Oct 1, 10:53 PM
Unknown Object (File)
Aug 25 2026, 2:45 AM
Unknown Object (File)
Aug 21 2026, 2:04 PM
Unknown Object (File)
Aug 14 2026, 2:49 AM
View All Files
Subscribers
Korvin

Details

Reviewers
epriestley
Commits
rP6e25d4c67b1a: Update Settings for WHITE_CONFIG style boxes
Summary

Updates settings panel UI for new white box, cleans up other various UI nitpicks.

Test Plan

Click through each setting that had a local setting page. Edit Engine pages will follow up on another diff.

Diff Detail

Repository
rP Phabricator
Branch
settings-config-box (branched from master)
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 18274
Build 24583: Run Core Tests
Build 24582: arc lint + arc unit

Event Timeline

chad created this revision.Sep 4 2017, 7:59 PM
Herald added a subscriber: Korvin. · View Herald TranscriptSep 4 2017, 7:59 PM
chad added a parent revision: D18519: Config re-design.Sep 4 2017, 8:00 PM
Harbormaster completed remote builds in B18274: Diff 44490.Sep 4 2017, 8:00 PM
chad added a child revision: D18527: Update EditEngine pages to take a page header separate.Sep 4 2017, 10:35 PM
chad updated this revision to Diff 44493.Sep 4 2017, 11:21 PM
  • update two separate panels
Harbormaster completed remote builds in B18277: Diff 44493.Sep 4 2017, 11:22 PM
epriestley accepted this revision.Sep 5 2017, 1:13 PM
This revision is now accepted and ready to land.Sep 5 2017, 1:13 PM
chad updated this revision to Diff 44529.Sep 6 2017, 2:25 AM
  • rebase?
Harbormaster completed remote builds in B18312: Diff 44529.Sep 6 2017, 2:26 AM
chad updated this revision to Diff 44530.Sep 6 2017, 2:41 AM
  • fix rebase
Harbormaster completed remote builds in B18313: Diff 44530.Sep 6 2017, 2:42 AM
Closed by commit rP6e25d4c67b1a: Update Settings for WHITE_CONFIG style boxes (authored by Chad Little <chad@phacility.com>). · Explain WhySep 6 2017, 2:42 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 44490

View Options

src/applications/settings/panel/PhabricatorActivitySettingsPanel.php

Loading...
View Options

src/applications/settings/panel/PhabricatorEmailAddressesSettingsPanel.php

Loading...
View Options

src/applications/settings/panel/PhabricatorEmailPreferencesSettingsPanel.php

Loading...
View Options

src/applications/settings/panel/PhabricatorExternalAccountsSettingsPanel.php

Loading...
View Options

src/applications/settings/panel/PhabricatorMultiFactorSettingsPanel.php

Loading...
View Options

src/applications/settings/panel/PhabricatorNotificationsSettingsPanel.php

Loading...
View Options

src/applications/settings/panel/PhabricatorPasswordSettingsPanel.php

Loading...
View Options

src/applications/settings/panel/PhabricatorSSHKeysSettingsPanel.php

Loading...
View Options

src/applications/settings/panel/PhabricatorSessionsSettingsPanel.php

Loading...
View Options

src/applications/settings/panel/PhabricatorSettingsPanel.php

Loading...
View Options

src/applications/settings/panel/PhabricatorTokensSettingsPanel.php

Loading...
Phabricator · Built by Phacility