Differential D18436

Update Settings to use TwoColumn fixed layout
ClosedPublic
Actions

Authored by chad on Aug 17 2017, 3:13 AM.

Details

Reviewers

epriestley

Commits

rPdc10bb1f4980: Update Settings to use TwoColumn fixed layout

Summary

Simplifies the page, adds base support for PHUITwoColumn fixed from Instances (which I'll delete css there).

Test Plan

click on every settings page, UI seems in tact, check mobile, desktop, mobile menus.

Diff Detail

Repository

rP Phabricator

Branch

fixed-settings (branched from master)

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 18087
Build 24301: Run Core Tests
Build 24300: arc lint + arc unit

Event Timeline

chad created this revision.Aug 17 2017, 3:13 AM

Herald added a subscriber: Korvin. · View Herald TranscriptAug 17 2017, 3:13 AM

Harbormaster completed remote builds in B18087: Diff 44296.Aug 17 2017, 3:15 AM

chad edited the summary of this revision. (Show Details)Aug 17 2017, 3:15 AM

chad edited the test plan for this revision. (Show Details)

epriestley accepted this revision.Aug 17 2017, 2:36 PM

This revision is now accepted and ready to land.Aug 17 2017, 2:36 PM

Closed by commit rPdc10bb1f4980: Update Settings to use TwoColumn fixed layout (authored by Chad Little <chad@phacility.com>). · Explain WhyAug 17 2017, 3:51 PM

This revision was automatically updated to reflect the committed changes.

epriestley mentioned this in D20005: Expand "Settings" UI to full-width.Jan 21 2019, 6:03 PM

epriestley mentioned this in rPf713fa1fd7ec: Expand "Settings" UI to full-width.Jan 23 2019, 9:40 PM

Revision Contents
Changeset List

Path

Size

resources/

celerity/

map.php

6 lines

src/

applications/

settings/

controller/

PhabricatorSettingsMainController.php

8 lines

panel/

PhabricatorConpherencePreferencesSettingsPanel.php

2 lines

transactions/

editengine/

PhabricatorEditEngine.php

13 lines

webroot/

rsrc/

css/

phui/

phui-two-column-view.css

51 lines

Diff 44296

View Options

resources/celerity/map.php

View Options

src/applications/settings/controller/PhabricatorSettingsMainController.php

View Options

src/applications/settings/panel/PhabricatorConpherencePreferencesSettingsPanel.php

View Options

src/applications/transactions/editengine/PhabricatorEditEngine.php

View Options

webroot/rsrc/css/phui/phui-two-column-view.css

Update Settings to use TwoColumn fixed layoutClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 44296

resources/celerity/map.php

src/applications/settings/controller/PhabricatorSettingsMainController.php

src/applications/settings/panel/PhabricatorConpherencePreferencesSettingsPanel.php

src/applications/transactions/editengine/PhabricatorEditEngine.php

webroot/rsrc/css/phui/phui-two-column-view.css

Update Settings to use TwoColumn fixed layout
ClosedPublic
Actions

Revision Contents
Changeset List