Page MenuHomePhabricator

Convert straggling Herald rules to modern revision status constants
ClosedPublic

Authored by epriestley on Aug 11 2017, 11:06 PM.

Details

Summary

Ref T2543. These are the last ArcanistDifferentialRevisionStatus callsites.

This removes the very old legacy precommitRevisionStatus field, which has no other readers. This was obsoleted by the CLOSED_FROM_ACCEPTED stuff, but retained for compatibility.

Test Plan
  • Poked these with the test console, although they're a little tricky to be sure about.
  • Grepped for ArcanistDifferentialRevisionStatus, no more hits.

Diff Detail

Repository
rP Phabricator
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

epriestley created this revision.Aug 11 2017, 11:06 PM
chad accepted this revision.Aug 11 2017, 11:52 PM
This revision is now accepted and ready to land.Aug 11 2017, 11:52 PM
This revision was automatically updated to reflect the committed changes.