Page MenuHomePhabricator

Convert straggling Herald rules to modern revision status constants
ClosedPublic

Authored by epriestley on Aug 11 2017, 11:06 PM.
Tags
None
Referenced Files
F19060528: D18416.diff
Sat, Nov 29, 9:33 AM
F18849803: D18416.id.diff
Thu, Oct 30, 12:20 PM
F18847031: D18416.id.diff
Oct 29 2025, 10:31 PM
F18845124: D18416.diff
Oct 29 2025, 9:55 AM
F18670875: D18416.diff
Sep 25 2025, 1:54 AM
F18654175: D18416.id44260.diff
Sep 22 2025, 3:39 AM
F18585390: D18416.diff
Sep 11 2025, 3:23 PM
F18509002: D18416.id.diff
Sep 5 2025, 3:09 AM
Subscribers
None

Details

Summary

Ref T2543. These are the last ArcanistDifferentialRevisionStatus callsites.

This removes the very old legacy precommitRevisionStatus field, which has no other readers. This was obsoleted by the CLOSED_FROM_ACCEPTED stuff, but retained for compatibility.

Test Plan
  • Poked these with the test console, although they're a little tricky to be sure about.
  • Grepped for ArcanistDifferentialRevisionStatus, no more hits.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable