Page MenuHomePhabricator

Convert straggling Herald rules to modern revision status constants
ClosedPublic

Authored by epriestley on Aug 11 2017, 11:06 PM.
Tags
None
Referenced Files
F15402442: D18416.id.diff
Mon, Mar 17, 10:34 PM
F15333049: D18416.diff
Fri, Mar 7, 11:24 PM
Unknown Object (File)
Feb 2 2025, 1:46 PM
Unknown Object (File)
Jan 31 2025, 12:20 AM
Unknown Object (File)
Jan 24 2025, 10:17 AM
Unknown Object (File)
Jan 22 2025, 5:03 AM
Unknown Object (File)
Jan 21 2025, 10:24 AM
Unknown Object (File)
Jan 12 2025, 5:56 AM
Subscribers
None

Details

Summary

Ref T2543. These are the last ArcanistDifferentialRevisionStatus callsites.

This removes the very old legacy precommitRevisionStatus field, which has no other readers. This was obsoleted by the CLOSED_FROM_ACCEPTED stuff, but retained for compatibility.

Test Plan
  • Poked these with the test console, although they're a little tricky to be sure about.
  • Grepped for ArcanistDifferentialRevisionStatus, no more hits.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable