Page MenuHomePhabricator

Remove remaining ArcanistDifferentialRevisionStatus references in revision state logic

Authored by epriestley on Aug 11 2017, 10:39 PM.



Ref T2543. This cleans up all the "when no one is rejecting/blocking and someone accepted, mark the revision overall as accepted" logic to use more modern status stuff instead of ArcanistDifferentialRevisionStatus.

Test Plan
  • Updated revisions, saw them go to "Needs Review".
  • Accepted, requested changes to revisions.
  • Updated one with changes requested, saw it go to "needs review" again.

Diff Detail

rP Phabricator
Automatic diff as part of commit; lint not applicable.
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

epriestley created this revision.Aug 11 2017, 10:39 PM
chad accepted this revision.Aug 11 2017, 10:46 PM
This revision is now accepted and ready to land.Aug 11 2017, 10:46 PM
This revision was automatically updated to reflect the committed changes.