Page MenuHomePhabricator

Remove remaining ArcanistDifferentialRevisionStatus references in revision state logic
ClosedPublic

Authored by epriestley on Aug 11 2017, 10:39 PM.
Tags
None
Referenced Files
F15695170: D18413.diff
Wed, May 28, 9:26 AM
Unknown Object (File)
Sun, May 18, 3:47 PM
Unknown Object (File)
Mon, May 5, 4:35 AM
Unknown Object (File)
Apr 28 2025, 5:19 PM
Unknown Object (File)
Apr 27 2025, 1:13 PM
Unknown Object (File)
Apr 27 2025, 8:08 AM
Unknown Object (File)
Apr 26 2025, 6:29 AM
Unknown Object (File)
Apr 14 2025, 2:24 AM
Subscribers
None

Details

Summary

Ref T2543. This cleans up all the "when no one is rejecting/blocking and someone accepted, mark the revision overall as accepted" logic to use more modern status stuff instead of ArcanistDifferentialRevisionStatus.

Test Plan
  • Updated revisions, saw them go to "Needs Review".
  • Accepted, requested changes to revisions.
  • Updated one with changes requested, saw it go to "needs review" again.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable