Page MenuHomePhabricator

Remove remaining ArcanistDifferentialRevisionStatus references in revision state logic
ClosedPublic

Authored by epriestley on Aug 11 2017, 10:39 PM.
Tags
None
Referenced Files
F17644241: D18413.diff
Fri, Jul 11, 10:22 PM
Unknown Object (File)
Wed, Jul 2, 4:57 AM
Unknown Object (File)
Jun 5 2025, 10:37 PM
Unknown Object (File)
Jun 3 2025, 11:30 PM
Unknown Object (File)
May 31 2025, 11:01 AM
Unknown Object (File)
May 29 2025, 5:10 PM
Unknown Object (File)
May 28 2025, 9:26 AM
Unknown Object (File)
May 18 2025, 3:47 PM
Subscribers
None

Details

Summary

Ref T2543. This cleans up all the "when no one is rejecting/blocking and someone accepted, mark the revision overall as accepted" logic to use more modern status stuff instead of ArcanistDifferentialRevisionStatus.

Test Plan
  • Updated revisions, saw them go to "Needs Review".
  • Accepted, requested changes to revisions.
  • Updated one with changes requested, saw it go to "needs review" again.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable