Page MenuHomePhabricator

Remove remaining ArcanistDifferentialRevisionStatus references in revision state logic
ClosedPublic

Authored by epriestley on Aug 11 2017, 10:39 PM.
Tags
None
Referenced Files
F18787775: D18413.id44257.diff
Wed, Oct 15, 1:30 AM
F18784496: D18413.id.diff
Mon, Oct 13, 12:46 PM
F18737093: D18413.diff
Oct 1 2025, 8:58 AM
F18548911: D18413.diff
Sep 8 2025, 8:17 AM
F18508999: D18413.id.diff
Sep 5 2025, 3:09 AM
F18501417: D18413.diff
Sep 4 2025, 9:44 PM
F18321436: D18413.diff
Aug 24 2025, 4:55 PM
F18094886: D18413.id.diff
Aug 7 2025, 10:24 PM
Subscribers
None

Details

Summary

Ref T2543. This cleans up all the "when no one is rejecting/blocking and someone accepted, mark the revision overall as accepted" logic to use more modern status stuff instead of ArcanistDifferentialRevisionStatus.

Test Plan
  • Updated revisions, saw them go to "Needs Review".
  • Accepted, requested changes to revisions.
  • Updated one with changes requested, saw it go to "needs review" again.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable