Page MenuHomePhabricator

Let `ArcanistNamespaceFirstStatementXHPASTLinterRule` support `declare` statements
Needs ReviewPublic

Authored by wjiang on Aug 6 2017, 12:52 PM.

Details

Reviewers
joshuaspence
Group Reviewers
Blessed Reviewers
Summary

declare statements should be put before the namespace statement. See Defining namespaces.
This improvement will be especially useful on PHP7 code where the use of declare(strict_types=1) is common.

Test Plan

Unit test

Diff Detail

Repository
rARC Arcanist
Branch
declare
Lint
Lint OK
Unit
Unit Tests OK
Build Status
Buildable 17924
Build 24074: arc lint + arc unit

Event Timeline

wjiang created this revision.Aug 6 2017, 12:52 PM

Maybe the name of ArcanistNamespaceFirstStatementXHPASTLinterRule is not quite proper now ? Perhaps ArcanistNamespaceStatementPositionXHPASTLinterRule could be replacement.

wjiang retitled this revision from Let `ArcanistNamespaceFirstStatementXHPASTLinterRule` support `declare` statemnts to Let `ArcanistNamespaceFirstStatementXHPASTLinterRule` support `declare` statements.Aug 6 2017, 12:56 PM
joshuaspence accepted this revision.Aug 6 2017, 1:21 PM
joshuaspence added inline comments.
src/lint/linter/xhpast/rules/ArcanistNamespaceFirstStatementXHPASTLinterRule.php
9

Given that the documentation lists this an an exception, I think it's fine to leave the name as-is.