declare statements should be put before the namespace statement. See Defining namespaces.
This improvement will be especially useful on PHP7 code where the use of declare(strict_types=1) is common.
Details
Details
- Reviewers
joshuaspence - Group Reviewers
Blessed Reviewers
Unit test
Diff Detail
Diff Detail
- Repository
- rARC Arcanist
- Branch
- declare
- Lint
Lint Passed - Unit
Tests Passed - Build Status
Buildable 17924 Build 24074: arc lint + arc unit
Event Timeline
Comment Actions
Maybe the name of ArcanistNamespaceFirstStatementXHPASTLinterRule is not quite proper now ? Perhaps ArcanistNamespaceStatementPositionXHPASTLinterRule could be replacement.
| src/lint/linter/xhpast/rules/ArcanistNamespaceFirstStatementXHPASTLinterRule.php | ||
|---|---|---|
| 9 | Given that the documentation lists this an an exception, I think it's fine to leave the name as-is. | |