Page MenuHomePhabricator

Skip Conduit call log writes in read-only mode, allowing "conduit.ping" to run
ClosedPublic

Authored by epriestley on Jul 18 2017, 3:51 PM.
Tags
None
Referenced Files
F12808002: D18233.diff
Wed, Mar 27, 8:15 PM
Unknown Object (File)
Jan 23 2024, 11:28 AM
Unknown Object (File)
Jan 11 2024, 12:16 PM
Unknown Object (File)
Dec 30 2023, 3:51 AM
Unknown Object (File)
Dec 25 2023, 12:08 AM
Unknown Object (File)
Dec 24 2023, 4:04 PM
Unknown Object (File)
Dec 21 2023, 12:31 AM
Unknown Object (File)
Dec 17 2023, 9:57 PM
Subscribers
None

Details

Summary

Ref T10769. See PHI8. We have an unconditional logging write which we can skip in read-only mode.

Test Plan
  • Put Phabricator in read-only mode with cluster.read-only.
  • Called conduit.ping via web UI.
    • Before: write-on-read-only exception.
    • After: good result.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable