Paths

Table of Contentst

Skip Conduit call log writes in read-only mode, allowing "conduit.ping" to run
ClosedPublic
Actions

Authored by epriestley on Jul 18 2017, 3:51 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Fri, Jan 10, 7:00 PM

	Unknown Object (File)
	Sat, Jan 4, 6:29 PM

	Unknown Object (File)
	Wed, Jan 1, 5:00 AM

	Unknown Object (File)
	Tue, Dec 24, 1:56 PM

	Unknown Object (File)
	Thu, Dec 19, 12:33 AM

	Unknown Object (File)
	Tue, Dec 17, 9:49 AM

	Unknown Object (File)
	Dec 13 2024, 11:59 AM

	Unknown Object (File)
	Dec 13 2024, 2:47 AM

View All Files

Subscribers

None

Details

Reviewers

chad
amckinley

Maniphest Tasks

T10769: Read-Only Mode Errata

Commits

rP4d1ed12a9e0a: Skip Conduit call log writes in read-only mode, allowing "conduit.ping" to run

Summary

Ref T10769. See PHI8. We have an unconditional logging write which we can skip in read-only mode.

Test Plan

Put Phabricator in read-only mode with cluster.read-only.
Called conduit.ping via web UI.
- Before: write-on-read-only exception.
- After: good result.

Diff Detail

Repository

rP Phabricator

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

epriestley created this revision.Jul 18 2017, 3:51 PM

Harbormaster completed remote builds in B17721: Diff 43856.Jul 18 2017, 3:52 PM

chad accepted this revision.Jul 18 2017, 8:31 PM

This revision is now accepted and ready to land.Jul 18 2017, 8:31 PM

Closed by commit rP4d1ed12a9e0a: Skip Conduit call log writes in read-only mode, allowing "conduit.ping" to run (authored by epriestley, committed by epriestley). · Explain WhyJul 18 2017, 8:32 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

conduit/

controller/

PhabricatorConduitAPIController.php

8 lines

Diff 43865

View Options

src/applications/conduit/controller/PhabricatorConduitAPIController.php

Skip Conduit call log writes in read-only mode, allowing "conduit.ping" to runClosedPublicActions