Page MenuHomePhabricator

Skip Conduit call log writes in read-only mode, allowing "conduit.ping" to run
ClosedPublic

Authored by epriestley on Jul 18 2017, 3:51 PM.
Tags
None
Referenced Files
F17628959: D18233.id43856.diff
Thu, Jul 10, 8:12 AM
Unknown Object (File)
May 31 2025, 10:59 AM
Unknown Object (File)
May 31 2025, 12:19 AM
Unknown Object (File)
May 27 2025, 1:37 PM
Unknown Object (File)
May 6 2025, 7:29 PM
Unknown Object (File)
May 6 2025, 3:39 PM
Unknown Object (File)
Apr 29 2025, 12:57 AM
Unknown Object (File)
Apr 26 2025, 5:36 AM
Subscribers
None

Details

Summary

Ref T10769. See PHI8. We have an unconditional logging write which we can skip in read-only mode.

Test Plan
  • Put Phabricator in read-only mode with cluster.read-only.
  • Called conduit.ping via web UI.
    • Before: write-on-read-only exception.
    • After: good result.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable