Fix comparison check for SVN in browsing Diffusion
ClosedPublic
Actions

Authored by chad on Jul 9 2017, 1:43 PM.

Tags

None

Referenced Files

	F17757506: D18190.diff
	Tue, Jul 22, 4:11 PM

	Unknown Object (File)
	May 26 2025, 7:33 AM

	Unknown Object (File)
	May 9 2025, 7:43 PM

	Unknown Object (File)
	May 8 2025, 4:30 AM

	Unknown Object (File)
	Apr 27 2025, 12:42 AM

	Unknown Object (File)
	Apr 12 2025, 5:26 PM

	Unknown Object (File)
	Apr 11 2025, 12:42 AM

	Unknown Object (File)
	Apr 6 2025, 6:21 PM

View All Files

Subscribers

Korvin

Details

Reviewers

epriestley

Maniphest Tasks

T12905: Diffusion browsing is broken for SVN

Commits

rP3480b3e7ef00: (stable) Fix comparison check for SVN in browsing Diffusion
rP0b3117bb684e: Fix comparison check for SVN in browsing Diffusion

Summary

Fixes T12905. Missed setting this variable.

Test Plan

Browse an SVN repository.

Diff Detail

Repository

rP Phabricator

Branch

fix-compare-svn (branched from master)

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 17644
Build 23686: Run Core Tests
Build 23685: arc lint + arc unit

Event Timeline

chad created this revision.Jul 9 2017, 1:43 PM

Herald added a subscriber: Korvin. · View Herald TranscriptJul 9 2017, 1:43 PM

Closed by commit rP0b3117bb684e: Fix comparison check for SVN in browsing Diffusion (authored by chad, committed by chad). · Explain WhyJul 9 2017, 1:43 PM

This revision was automatically updated to reflect the committed changes.

Harbormaster completed remote builds in B17644: Diff 43755.Jul 9 2017, 1:44 PM

Revision Contents
Changeset List

Path

Size

src/

applications/

diffusion/

controller/

DiffusionBrowseController.php

5 lines

Diff 43755

View Options

src/applications/diffusion/controller/DiffusionBrowseController.php

Fix comparison check for SVN in browsing DiffusionClosedPublicActions