HomePhabricator

Fix comparison check for SVN in browsing Diffusion

Description

Fix comparison check for SVN in browsing Diffusion

Summary: Fixes T12905. Missed setting this variable.

Test Plan: Browse an SVN repository.

Reviewers: epriestley

Subscribers: Korvin

Maniphest Tasks: T12905

Differential Revision: https://secure.phabricator.com/D18190

Event Timeline

I should cherry-pick this one to stable, right?

Yeah, or I meant to try to do that myself. I think it's just one command?

Yeah, pretty much:

$ git checkout stable
$ git cherry-pick <commit>
$ git commit --amend # Add "(stable)" at the beginning.
$ arc liberate # Amend if anything changes.
$ ./bin/celerity map # Amend if anything changes.
$ git push
$ git checkout master

Sometimes the git cherry-pick isn't clean and then it gets a little messier than this.

The manual commit step (where you type (stable)) can be expressed as git log -l 1 --format="(stable) %B" HEAD | git commit --amend -F - or something but it's probably easier to just type it manually.