Page MenuHomePhabricator

Let "<select />" EditEngine fields canonicalize saved defaults
ClosedPublic

Authored by epriestley on Jun 20 2017, 10:27 PM.
Tags
None
Referenced Files
F19019840: D18142.id.diff
Sun, Nov 23, 4:01 PM
F19010484: D18142.diff
Sat, Nov 22, 4:46 AM
F18830446: D18142.id43651.diff
Oct 25 2025, 6:49 AM
F18822403: D18142.id43652.diff
Oct 23 2025, 6:34 AM
F18800220: D18142.id.diff
Oct 17 2025, 3:54 PM
F18775321: D18142.id.diff
Oct 10 2025, 6:39 PM
F18733649: D18142.id.diff
Sep 30 2025, 10:39 PM
F18631597: D18142.id.diff
Sep 16 2025, 3:50 PM
Subscribers
None

Details

Summary

Ref T12124. After D18134 we accept either "25" or "low" via HTTP parameters and when the field renders as a control, but if the form has a default value for the field but locks or hides it we don't actually run through that logic.

Canonicalize both when rendering the control and when using a raw saved default value.

Test Plan
  • Created a form with "Priority: Low".
  • Hid the "Priority" field.
  • Before patch: Tried to create a task, was rebuffed with a (now verbose and helpful, after D18135) error.
  • Applied patch: things worked.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable