Page MenuHomePhabricator

Let "<select />" EditEngine fields canonicalize saved defaults
ClosedPublic

Authored by epriestley on Jun 20 2017, 10:27 PM.
Tags
None
Referenced Files
F14073409: D18142.diff
Thu, Nov 21, 12:30 AM
Unknown Object (File)
Sun, Nov 17, 8:28 AM
Unknown Object (File)
Sat, Nov 9, 2:09 PM
Unknown Object (File)
Sat, Nov 9, 2:09 PM
Unknown Object (File)
Sat, Nov 9, 2:09 PM
Unknown Object (File)
Tue, Nov 5, 11:55 PM
Unknown Object (File)
Sun, Nov 3, 6:13 PM
Unknown Object (File)
Sat, Oct 26, 12:11 AM
Subscribers
None

Details

Summary

Ref T12124. After D18134 we accept either "25" or "low" via HTTP parameters and when the field renders as a control, but if the form has a default value for the field but locks or hides it we don't actually run through that logic.

Canonicalize both when rendering the control and when using a raw saved default value.

Test Plan
  • Created a form with "Priority: Low".
  • Hid the "Priority" field.
  • Before patch: Tried to create a task, was rebuffed with a (now verbose and helpful, after D18135) error.
  • Applied patch: things worked.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable