Page MenuHomePhabricator

If the overseer can't update the PID file, just move on
ClosedPublic

Authored by epriestley on Jun 19 2017, 9:53 PM.
Tags
None
Referenced Files
F14493148: D18139.id43641.diff
Fri, Jan 3, 12:45 AM
Unknown Object (File)
Mon, Dec 30, 11:51 PM
Unknown Object (File)
Thu, Dec 12, 11:56 AM
Unknown Object (File)
Fri, Dec 6, 5:12 AM
Unknown Object (File)
Nov 27 2024, 2:15 PM
Unknown Object (File)
Nov 23 2024, 12:44 PM
Unknown Object (File)
Nov 19 2024, 12:51 AM
Unknown Object (File)
Nov 15 2024, 3:06 AM
Subscribers
None

Details

Summary

Ref T12857. This is a little murky, but this behavior seems clearly better.

When the disk is full, daemons may attempt to update their PID files and fail. When this happens, keep running rather than exiting.

Test Plan
  • Made Filesystem::writeFile() throw an exception unconditionally to simulate a full disk.
  • Ran bin/phd start.
  • Saw daemons exit immediately.
  • Applied patch, saw daemons stick around and do useful work instead.

Diff Detail

Repository
rPHU libphutil
Branch
pidfull
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 17533
Build 23523: Run Core Tests
Build 23522: arc lint + arc unit

Event Timeline

This revision is now accepted and ready to land.Jun 20 2017, 3:39 AM
This revision was automatically updated to reflect the committed changes.