HomePhabricator

Make empty Remarkup table rows have more intuitive behavior

Description

Make empty Remarkup table rows have more intuitive behavior

Summary:
Fixes T12849. Currently, when a row contains only empty cells and cells with "----" in them, we treat it as indicating which cells above should be rendered with <th /> instead of <td />.

This produces an unintuitive result when every cell is empty.

Instead, treat a row as a "headings" row only if it has at least one "---" cell in it.

Test Plan:
Added a unit test.

Note that the resulting row is empty, so it doesn't get normal line height.

Screen Shot 2017-06-19 at 3.20.08 PM.png (517×353 px, 22 KB)

Reviewers: chad

Reviewed By: chad

Maniphest Tasks: T12849

Differential Revision: https://secure.phabricator.com/D18140

Details

Provenance
epriestleyAuthored on Jun 19 2017, 10:20 PM
epriestleyPushed on Jun 20 2017, 12:43 PM
Reviewer
chad
Differential Revision
D18140: Make empty Remarkup table rows have more intuitive behavior
Parents
rPHU900873b4a4c5: Modernize editor selector
Branches
Unknown
Tags
Unknown
Tasks
T12849: No way to have an empty row in a remarkup table
Build Status
Buildable 17538
Build 23532: Run Core Tests