Page MenuHomePhabricator

If the overseer can't update the PID file, just move on
ClosedPublic

Authored by epriestley on Jun 19 2017, 9:53 PM.
Tags
None
Referenced Files
F15464524: D18139.id43641.diff
Wed, Apr 2, 10:13 AM
F15457754: D18139.id43641.diff
Sun, Mar 30, 6:27 PM
F15457318: D18139.diff
Sun, Mar 30, 3:36 PM
F15456211: D18139.id43647.diff
Sun, Mar 30, 7:52 AM
F15432244: D18139.id.diff
Mon, Mar 24, 4:59 PM
F15428699: D18139.diff
Sun, Mar 23, 9:46 PM
Unknown Object (File)
Feb 9 2025, 4:19 AM
Unknown Object (File)
Feb 9 2025, 4:19 AM
Subscribers
None

Details

Summary

Ref T12857. This is a little murky, but this behavior seems clearly better.

When the disk is full, daemons may attempt to update their PID files and fail. When this happens, keep running rather than exiting.

Test Plan
  • Made Filesystem::writeFile() throw an exception unconditionally to simulate a full disk.
  • Ran bin/phd start.
  • Saw daemons exit immediately.
  • Applied patch, saw daemons stick around and do useful work instead.

Diff Detail

Repository
rPHU libphutil
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

This revision is now accepted and ready to land.Jun 20 2017, 3:39 AM
This revision was automatically updated to reflect the committed changes.