Use visibility hidden on remarkup checkboxes
ClosedPublic
Actions

Authored by chad on Jun 18 2017, 6:52 AM.

Tags

None

Referenced Files

	F14728314: D18130.id43625.diff
	Sat, Jan 18, 5:27 AM

	F14722907: D18130.id43625.diff
	Fri, Jan 17, 11:56 PM

	Unknown Object (File)
	Sun, Jan 12, 2:43 PM

	Unknown Object (File)
	Tue, Jan 7, 12:20 AM

	Unknown Object (File)
	Thu, Dec 26, 10:59 AM

	Unknown Object (File)
	Fri, Dec 20, 11:23 PM

	Unknown Object (File)
	Fri, Dec 20, 3:00 PM

	Unknown Object (File)
	Dec 14 2024, 11:33 PM

View All Files

Subscribers

jboning

Korvin

Details

Reviewers

epriestley
amckinley
avivey

Maniphest Tasks

T12850: Checklists with dangling checkboxes overflow onto subsequent text

Commits

rP9540ed7ec2ee: Use visibility hidden on remarkup checkboxes

Summary

Fixes T12850, marks it hidden with zero width so the element still exists in the DOM

Test Plan

T12850 code, locally

Diff Detail

Repository

rP Phabricator

Branch

checkboxes (branched from master)

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 17517
Build 23495: Run Core Tests
Build 23494: arc lint + arc unit

Event Timeline

chad created this revision.Jun 18 2017, 6:52 AM

Herald added a subscriber: Korvin. · View Herald TranscriptJun 18 2017, 6:52 AM

Harbormaster completed remote builds in B17517: Diff 43625.Jun 18 2017, 6:53 AM

avivey accepted this revision.Jun 18 2017, 7:53 AM

This revision is now accepted and ready to land.Jun 18 2017, 7:53 AM

Closed by commit rP9540ed7ec2ee: Use visibility hidden on remarkup checkboxes (authored by chad, committed by chad). · Explain WhyJun 18 2017, 8:00 AM

This revision was automatically updated to reflect the committed changes.

Much nicer! Thank you!

Revision Contents
Changeset List

Path

Size

resources/

celerity/

map.php

6 lines

webroot/

rsrc/

css/

core/

remarkup.css

3 lines

Diff 43625

View Options

resources/celerity/map.php