Ref T12780. I'd like 18,000 GitHub stars now please thank you
Details
Details
- Reviewers
chad - Maniphest Tasks
- T12780: Icons look bad in HistoryTableView
- Commits
- rPf2fcafb40dde: Help PROFESSIONAL SOFTWARE ENGINEERS copy text to their clipboard
this feature is awful
Diff Detail
Diff Detail
- Repository
- rP Phabricator
- Branch
- copy
- Lint
Lint Warnings Severity Location Code Message Warning webroot/rsrc/js/core/behavior-copy.js:1 JAVELIN5 `javelinsymbols` Not In Path - Unit
Tests Passed - Build Status
Buildable 17336 Build 23232: Run Core Tests
Event Timeline
| src/applications/uiexample/examples/PHUIButtonExample.php | ||
|---|---|---|
| 109–112 | Bonus: now supports internationalization! | |
Comment Actions
Other improvements I'm excited to pursue:
- A large "Close Window" button in the upper left corner of the screen to help PROFESSIONAL SOFTWARE ENGINEERS close windows.
- A large "More Content Below! Click Here To Scroll Down!" fixed position footer banner to help PROFESSIONAL SOFTWARE ENGINEERS scroll through documents.
- A large "← ← ← Back! Click Here To Go Back To The Last Page! ← ← ←" element along the left side of the screen to help PROFESSIONAL SOFTWARE ENGINEERS navigate through workflows.
Comment Actions
Yes, we're already heavily committed to helping PROFESSIONAL SOFTWARE ENGINEERS open several different web documents in the same browser window.
Comment Actions
I'm currently making this element degrade by hiding it on page load, testing if "copy" will work, and then showing it.
This may cause some flickering on load, and/or may cause some layout/design issues down the road because I'm using visibility: hidden. If so, we could do something like: always show it, always let users click it, say "copied YES GREAT" or "not supported by your browser, sorry" after the action fires.