Page MenuHomePhabricator
Differential D18048

Make "simple" a "button type", not a "color"
ClosedPublic
Actions

Authored by epriestley on May 30 2017, 9:41 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Nov 24, 7:15 PM
Unknown Object (File)
Sun, Nov 24, 11:50 AM
Unknown Object (File)
Sun, Nov 24, 11:25 AM
Unknown Object (File)
Sat, Nov 23, 2:08 PM
Unknown Object (File)
Sat, Nov 16, 9:46 PM
Unknown Object (File)
Thu, Nov 14, 4:42 AM
Unknown Object (File)
Sun, Nov 10, 9:06 PM
Unknown Object (File)
Oct 19 2024, 2:42 AM
View All Files
Subscribers
None

Details

Reviewers
chad
Commits
rP2c0dab055f73: Make "simple" a "button type", not a "color"
Summary

Ref M1476. Currently, setColor('simple') is meaningful. Instead, setButtonType('simple').

Depends on D18047.

Test Plan

Looked at UI examples, Phame, Auth. Notifications mooted by D18047.

Diff Detail

Repository
rP Phabricator
Branch
head4
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 17319
Build 23208: Run Core Tests
Build 23207: arc lint + arc unit

Event Timeline

epriestley created this revision.May 30 2017, 9:41 PM
epriestley added a comment.May 30 2017, 9:42 PM

Open to other word choice here, but setStyle() sounds like HTML style="..." attributes.

Harbormaster completed remote builds in B17319: Diff 43406.May 30 2017, 9:43 PM
chad accepted this revision.May 30 2017, 9:45 PM
This revision is now accepted and ready to land.May 30 2017, 9:45 PM
chad added a comment.May 30 2017, 9:45 PM

I think we usually do "setType" but I hate not being able to easily grep that.

Alternative: setButtonType

epriestley updated this revision to Diff 43407.May 30 2017, 9:50 PM
epriestley retitled this revision from Make "simple" a "design", not a "color" to Make "simple" a "button type", not a "color".
epriestley edited the summary of this revision. (Show Details)
  • "Design" -> "Button Type"
Harbormaster completed remote builds in B17320: Diff 43407.May 30 2017, 9:51 PM
Closed by commit rP2c0dab055f73: Make "simple" a "button type", not a "color" (authored by epriestley, committed by epriestley). · Explain WhyMay 31 2017, 12:59 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
applications/
auth/
controller/
config/
2 lines
guides/
view/
2 lines
phame/
query/
2 lines
uiexample/
examples/
10 lines
4 lines
8 lines
view/
phui/
22 lines
2 lines

Diff 43406

View Options

src/applications/auth/controller/config/PhabricatorAuthListController.php

Loading...
View Options

src/applications/guides/view/PhabricatorGuideListView.php

Loading...
View Options

src/applications/phame/query/PhameBlogSearchEngine.php

Loading...
View Options

src/applications/uiexample/examples/PHUIBoxExample.php

Loading...
View Options

src/applications/uiexample/examples/PHUIButtonBarExample.php

Loading...
View Options

src/applications/uiexample/examples/PHUIButtonExample.php

Loading...
View Options

src/view/phui/PHUIButtonView.php

Loading...
View Options

src/view/phui/PHUIDocumentViewPro.php

Loading...
Phabricator · Built by Phacility