Page MenuHomePhabricator

Make "simple" a "button type", not a "color"
ClosedPublic

Authored by epriestley on May 30 2017, 9:41 PM.
Tags
None
Referenced Files
F14086141: D18048.id43419.diff
Sat, Nov 23, 2:08 PM
Unknown Object (File)
Sat, Nov 16, 9:46 PM
Unknown Object (File)
Thu, Nov 14, 4:42 AM
Unknown Object (File)
Sun, Nov 10, 9:06 PM
Unknown Object (File)
Oct 19 2024, 2:42 AM
Unknown Object (File)
Oct 14 2024, 6:51 AM
Unknown Object (File)
Sep 30 2024, 5:48 PM
Unknown Object (File)
Sep 25 2024, 7:01 AM
Subscribers
None

Details

Summary

Ref M1476. Currently, setColor('simple') is meaningful. Instead, setButtonType('simple').

Depends on D18047.

Test Plan

Looked at UI examples, Phame, Auth. Notifications mooted by D18047.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Open to other word choice here, but setStyle() sounds like HTML style="..." attributes.

This revision is now accepted and ready to land.May 30 2017, 9:45 PM

I think we usually do "setType" but I hate not being able to easily grep that.

Alternative: setButtonType

epriestley retitled this revision from Make "simple" a "design", not a "color" to Make "simple" a "button type", not a "color".
epriestley edited the summary of this revision. (Show Details)
  • "Design" -> "Button Type"
This revision was automatically updated to reflect the committed changes.