Page MenuHomePhabricator
Differential D18045

Add a class to the Differential banner when unsubmitted/unsaved changes are present
ClosedPublic
Actions

Authored by epriestley on May 30 2017, 9:04 PM.
Tags
None
Referenced Files
F19073490: D18045.id43400.diff
Mon, Dec 1, 2:19 AM
F19034328: D18045.id43418.diff
Tue, Nov 25, 2:05 PM
F19013589: D18045.id43401.diff
Sat, Nov 22, 4:29 PM
F18976175: D18045.diff
Nov 16 2025, 12:28 PM
F18904050: D18045.id.diff
Nov 8 2025, 7:30 AM
F18849092: D18045.id43401.diff
Oct 30 2025, 7:43 AM
F18824781: D18045.id.diff
Oct 23 2025, 5:55 PM
F18820342: D18045.diff
Oct 22 2025, 2:21 PM
View All Files
Subscribers
None

Details

Reviewers
chad
Maniphest Tasks
T12733: (2017 Week 20) Inline Comments Errata / Feedback
Commits
rP83e99fb691aa: Add a class to the Differential banner when unsubmitted/unsaved changes are…
Summary

Ref T12733. This adds classes for unsubmitted/unsaved changes, and lays some groundwork for additional buttons.

Test Plan
  • Added, edited, deleted comments.
  • Saw bar background color update appropriately.

Diff Detail

Repository
rP Phabricator
Branch
head3
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 17314
Build 23200: Run Core Tests
Build 23199: arc lint + arc unit

Revision Contents
Changeset List

PathSize
resources/
celerity/
60 lines
webroot/
rsrc/
css/
application/
differential/
5 lines
js/
application/
diff/
5 lines
42 lines
16 lines

Diff 43401

View Options

resources/celerity/map.php

Loading...
View Options

webroot/rsrc/css/application/differential/changeset-view.css

Loading...
View Options

webroot/rsrc/js/application/diff/DiffChangeset.js

Loading...
View Options

webroot/rsrc/js/application/diff/DiffChangesetList.js

Loading...
View Options

webroot/rsrc/js/application/diff/DiffInline.js

Loading...
Phabricator · Built by Phacility