Page MenuHomePhabricator

Add a class to the Differential banner when unsubmitted/unsaved changes are present
ClosedPublic

Authored by epriestley on May 30 2017, 9:04 PM.
Tags
None
Referenced Files
F18087024: D18045.id43401.diff
Wed, Aug 6, 1:51 AM
F18084930: D18045.id.diff
Tue, Aug 5, 6:53 PM
F18054591: D18045.diff
Mon, Aug 4, 6:23 AM
Unknown Object (File)
May 31 2025, 10:57 AM
Unknown Object (File)
May 29 2025, 2:10 PM
Unknown Object (File)
May 6 2025, 11:20 PM
Unknown Object (File)
May 5 2025, 8:10 PM
Unknown Object (File)
May 5 2025, 5:16 PM
Subscribers
None

Details

Summary

Ref T12733. This adds classes for unsubmitted/unsaved changes, and lays some groundwork for additional buttons.

Test Plan
  • Added, edited, deleted comments.
  • Saw bar background color update appropriately.

Diff Detail

Repository
rP Phabricator
Branch
head3
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 17313
Build 23198: Run Core Tests
Build 23197: arc lint + arc unit

Unit TestsFailed

TimeTest
241 msPhabricatorCelerityTestCase::Unknown Unit Message ("")
Assertion failed, expected 'true' (at PhabricatorCelerityTestCase.php:32): When this test fails, it means the Celerity resource map is out of date. Run `bin/celerity map` to rebuild it. ACTUAL VALUE
1 msAlmanacNamesTestCase::Unknown Unit Message ("")
30 assertions passed.
0 msAlmanacServiceTypeTestCase::Unknown Unit Message ("")
1 assertion passed.
0 msAphrontHTTPSinkTestCase::Unknown Unit Message ("")
6 assertions passed.
0 msAphrontHTTPSinkTestCase::Unknown Unit Message ("")
4 assertions passed.
View Full Test Results (1 Failed · 337 Passed)