Differential D18045

Add a class to the Differential banner when unsubmitted/unsaved changes are present
ClosedPublic
Actions

Authored by epriestley on May 30 2017, 9:04 PM.

Details

Reviewers

chad

Maniphest Tasks

T12733: (2017 Week 20) Inline Comments Errata / Feedback

Commits

rP83e99fb691aa: Add a class to the Differential banner when unsubmitted/unsaved changes are…

Summary

Ref T12733. This adds classes for unsubmitted/unsaved changes, and lays some groundwork for additional buttons.

Test Plan

Added, edited, deleted comments.
Saw bar background color update appropriately.

Diff Detail

Repository

rP Phabricator

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

epriestley created this revision.May 30 2017, 9:04 PM

Harbormaster failed remote builds in B17313: Diff 43400!May 30 2017, 9:05 PM

Celerity map.

Harbormaster completed remote builds in B17314: Diff 43401.May 30 2017, 9:07 PM

chad accepted this revision.May 30 2017, 10:48 PM

This revision is now accepted and ready to land.May 30 2017, 10:48 PM

Closed by commit rP83e99fb691aa: Add a class to the Differential banner when unsubmitted/unsaved changes are… (authored by epriestley, committed by epriestley). · Explain WhyMay 31 2017, 12:59 AM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

resources/

celerity/

map.php

60 lines

webroot/

rsrc/

css/

application/

differential/

changeset-view.css

5 lines

js/

application/

diff/

DiffChangeset.js

5 lines

DiffChangesetList.js

42 lines

DiffInline.js

16 lines

Diff 43418

View Options

resources/celerity/map.php

View Options

webroot/rsrc/css/application/differential/changeset-view.css

View Options

webroot/rsrc/js/application/diff/DiffChangeset.js

View Options

webroot/rsrc/js/application/diff/DiffChangesetList.js

View Options

webroot/rsrc/js/application/diff/DiffInline.js

Add a class to the Differential banner when unsubmitted/unsaved changes are presentClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 43418

resources/celerity/map.php

webroot/rsrc/css/application/differential/changeset-view.css

webroot/rsrc/js/application/diff/DiffChangeset.js

webroot/rsrc/js/application/diff/DiffChangesetList.js

webroot/rsrc/js/application/diff/DiffInline.js

Add a class to the Differential banner when unsubmitted/unsaved changes are present
ClosedPublic
Actions

Revision Contents
Changeset List