Page MenuHomePhabricator

Allow Nuance commands to try to apply immediately
ClosedPublic

Authored by epriestley on May 24 2017, 8:27 PM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Jun 27, 6:17 AM
Unknown Object (File)
Sun, Jun 26, 7:23 AM
Unknown Object (File)
Sun, Jun 19, 12:41 AM
Unknown Object (File)
Tue, Jun 14, 3:53 AM
Unknown Object (File)
Mon, Jun 6, 8:23 PM
Unknown Object (File)
May 31 2022, 1:49 PM
Unknown Object (File)
May 24 2022, 11:56 AM
Subscribers

Details

Summary

Ref T12738. By default, we process Nuance commands in the background. The intent is to let the user continue working at full speed if Twitter or GitHub (or whatever) is being a little slow.

Some commands don't do anything heavy and can be processed in the foreground. Let commands choose to try foreground execution.

Test Plan

Threw complaints in the trash, saw them immediately go into the trash.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

This revision is now accepted and ready to land.May 24 2017, 8:38 PM

mmm

Anecdotally, In T9530 we had a concept of "Actions" that users can take on Releases - e.g. "Move to the next phase in the cycle". We broadly wanted to use Harbormaster to allow defining these actions, and one of the issues I had there was that for some actions, the users expected them to happen inline, pretty much like here.

This revision was automatically updated to reflect the committed changes.