Differential D18015

Allow Nuance commands to try to apply immediately
ClosedPublic
Actions

Authored by epriestley on May 24 2017, 8:27 PM.

Details

Reviewers

chad

Maniphest Tasks

T12738: Nuance: As a Helpdesk, for Phabricator/Phacility support

Commits

rP5b43d5c89ccc: Allow Nuance commands to try to apply immediately

Summary

Ref T12738. By default, we process Nuance commands in the background. The intent is to let the user continue working at full speed if Twitter or GitHub (or whatever) is being a little slow.

Some commands don't do anything heavy and can be processed in the foreground. Let commands choose to try foreground execution.

Test Plan

Threw complaints in the trash, saw them immediately go into the trash.

Diff Detail

Repository

rP Phabricator

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

epriestley created this revision.May 24 2017, 8:27 PM

Harbormaster completed remote builds in B17241: Diff 43329.May 24 2017, 8:28 PM

chad accepted this revision.May 24 2017, 8:38 PM

This revision is now accepted and ready to land.May 24 2017, 8:38 PM

mmm

Anecdotally, In T9530 we had a concept of "Actions" that users can take on Releases - e.g. "Move to the next phase in the cycle". We broadly wanted to use Harbormaster to allow defining these actions, and one of the issues I had there was that for some actions, the users expected them to happen inline, pretty much like here.

Closed by commit rP5b43d5c89ccc: Allow Nuance commands to try to apply immediately (authored by epriestley). · Explain WhyMay 26 2017, 3:36 PM

This revision was automatically updated to reflect the committed changes.