Page MenuHomePhabricator

Allow Nuance commands to try to apply immediately
ClosedPublic

Authored by epriestley on May 24 2017, 8:27 PM.
Tags
None
Referenced Files
Unknown Object (File)
Feb 18 2024, 10:42 PM
Unknown Object (File)
Feb 3 2024, 4:00 PM
Unknown Object (File)
Jan 16 2024, 9:58 AM
Unknown Object (File)
Jan 1 2024, 5:05 PM
Unknown Object (File)
Dec 29 2023, 3:47 PM
Unknown Object (File)
Dec 28 2023, 4:46 PM
Unknown Object (File)
Dec 27 2023, 11:15 AM
Unknown Object (File)
Dec 27 2023, 11:15 AM
Subscribers

Details

Summary

Ref T12738. By default, we process Nuance commands in the background. The intent is to let the user continue working at full speed if Twitter or GitHub (or whatever) is being a little slow.

Some commands don't do anything heavy and can be processed in the foreground. Let commands choose to try foreground execution.

Test Plan

Threw complaints in the trash, saw them immediately go into the trash.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

This revision is now accepted and ready to land.May 24 2017, 8:38 PM

mmm

Anecdotally, In T9530 we had a concept of "Actions" that users can take on Releases - e.g. "Move to the next phase in the cycle". We broadly wanted to use Harbormaster to allow defining these actions, and one of the issues I had there was that for some actions, the users expected them to happen inline, pretty much like here.

This revision was automatically updated to reflect the committed changes.