Yeah, ⌘+F hits nothing.

We could probably detect this in lint, it just doesn't come up too terribly often.

Oh, I think we'd get false positives right now because the linter doesn't do a great job of "{$variable}" in strings until T8049, maybe?

In D17967#217679, @epriestley wrote:

Yeah, ⌘+F hits nothing.

We could probably detect this in lint, it just doesn't come up too terribly often.

I'd love a lint rule for this. I bet it would prevent typos more than anything else, but in PHP that seems extremely useful.

We can detect this version of things ("use of undeclared variable"), which I think gets most of the typos:

Error  (XHP5) Use of Undeclared Variable
 Declare variables prior to use (even if you are passing them as reference
 parameters). You may have misspelled this variable name.

           25 
           26     $manage_uri = $this->getApplicationURI('manage/'.$project->getID().'/');
           27 
 >>>       28     do_a_thing($maneg_yoori);
           29 
           30     $supported_formats = PhabricatorFile::getTransformableImageFormats();
           31     $e_file = true;

We just can't currently detect the opposite, "declared but unused variable".

Filed as T12734.

(Also just playing around with the new sidebar thing.)