Page MenuHomePhabricator

Fix "left"/"right" changeset ID selection for synthetic deletions
ClosedPublic

Authored by epriestley on May 17 2017, 3:27 PM.
Tags
None
Referenced Files
F15380821: D17929.id.diff
Fri, Mar 14, 4:37 AM
Unknown Object (File)
Feb 9 2025, 4:06 AM
Unknown Object (File)
Feb 9 2025, 4:06 AM
Unknown Object (File)
Feb 9 2025, 4:06 AM
Unknown Object (File)
Feb 9 2025, 4:06 AM
Unknown Object (File)
Jan 24 2025, 9:04 PM
Unknown Object (File)
Jan 24 2025, 9:04 PM
Unknown Object (File)
Jan 24 2025, 9:04 PM
Subscribers
None

Details

Summary

Fixes T8323. See that task for a description.

We were using nonempty(), but that rule doesn't cover synthetic deletions (file present in an earlier diff, but no longer present in the later diff).

Test Plan

Followed the steps in T8323, got a clean comment.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

This revision is now accepted and ready to land.May 17 2017, 3:31 PM
This revision was automatically updated to reflect the committed changes.